Fix subscript[0] in utilstrencodings.cpp

JeremyRubin · JeremyRubin · commit e19db7b5ad6a · 2017-07-08T13:33:01.000-07:00
diff --git a/src/utilstrencodings.cpp b/src/utilstrencodings.cpp
@@ -228,7 +228,7 @@ std::vector<unsigned char> DecodeBase64(const char* p, bool* pfInvalid)
 std::string DecodeBase64(const std::string& str)
 {
     std::vector<unsigned char> vchRet = DecodeBase64(str.c_str());
-    return (vchRet.size() == 0) ? std::string() : std::string((const char*)&vchRet[0], vchRet.size());
+    return (vchRet.size() == 0) ? std::string() : std::string((const char*)vchRet.data(), vchRet.size());
 }
 
 std::string EncodeBase32(const unsigned char* pch, size_t len)
@@ -415,7 +415,7 @@ std::vector<unsigned char> DecodeBase32(const char* p, bool* pfInvalid)
 std::string DecodeBase32(const std::string& str)
 {
     std::vector<unsigned char> vchRet = DecodeBase32(str.c_str());
-    return (vchRet.size() == 0) ? std::string() : std::string((const char*)&vchRet[0], vchRet.size());
+    return (vchRet.size() == 0) ? std::string() : std::string((const char*) vchRet.data(), vchRet.size());
 }
 
 static bool ParsePrechecks(const std::string& str)

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ std::vector<unsigned char> DecodeBase64(const char* p, bool* pfInvalid)`
`228`	`228`	`std::string DecodeBase64(const std::string& str)`
`229`	`229`	`{`
`230`	`230`	`std::vector<unsigned char> vchRet = DecodeBase64(str.c_str());`
`231`		`- return (vchRet.size() == 0) ? std::string() : std::string((const char*)&vchRet[0], vchRet.size());`
	`231`	`+ return (vchRet.size() == 0) ? std::string() : std::string((const char*)vchRet.data(), vchRet.size());`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`std::string EncodeBase32(const unsigned char* pch, size_t len)`
`@@ -415,7 +415,7 @@ std::vector<unsigned char> DecodeBase32(const char* p, bool* pfInvalid)`
`415`	`415`	`std::string DecodeBase32(const std::string& str)`
`416`	`416`	`{`
`417`	`417`	`std::vector<unsigned char> vchRet = DecodeBase32(str.c_str());`
`418`		`- return (vchRet.size() == 0) ? std::string() : std::string((const char*)&vchRet[0], vchRet.size());`
	`418`	`+ return (vchRet.size() == 0) ? std::string() : std::string((const char*) vchRet.data(), vchRet.size());`
`419`	`419`	`}`
`420`	`420`
`421`	`421`	`static bool ParsePrechecks(const std::string& str)`