Optimize vInOutPoints insertion a bit

TheBlueMatt · TheBlueMatt · commit e2b3fb349ed9 · 2016-11-09T11:28:41.000-08:00
diff --git a/src/main.cpp b/src/main.cpp
@@ -1133,9 +1133,8 @@ bool CheckTransaction(const CTransaction& tx, CValidationState &state, bool fChe
         set<COutPoint> vInOutPoints;
         for (const auto& txin : tx.vin)
         {
-            if (vInOutPoints.count(txin.prevout))
+            if (!vInOutPoints.insert(txin.prevout).second)
                 return state.DoS(100, false, REJECT_INVALID, "bad-txns-inputs-duplicate");
-            vInOutPoints.insert(txin.prevout);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1133,9 +1133,8 @@ bool CheckTransaction(const CTransaction& tx, CValidationState &state, bool fChe`
`1133`	`1133`	`set<COutPoint> vInOutPoints;`
`1134`	`1134`	`for (const auto& txin : tx.vin)`
`1135`	`1135`	`{`
`1136`		`- if (vInOutPoints.count(txin.prevout))`
	`1136`	`+ if (!vInOutPoints.insert(txin.prevout).second)`
`1137`	`1137`	`return state.DoS(100, false, REJECT_INVALID, "bad-txns-inputs-duplicate");`
`1138`		`- vInOutPoints.insert(txin.prevout);`
`1139`	`1138`	`}`
`1140`	`1139`	`}`
`1141`	`1140`