Skip to content

Commit e478b11

Browse files
author
MarcoFalke
committed
Merge #19110: test: Explain that a bug should be filed when the tests fail
fad21a1 test: Explain that a bug should be filed when the test fail (MarcoFalke) Pull request description: Without a bug report it is harder to fix the issue ACKs for top commit: hebasto: ACK fad21a1, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. fanquake: ACK fad21a1 Tree-SHA512: db194e8f8c0f07b2f4c9ef27e456510959f89da69435cee71605d720e0ad06f18700973f5af25ea31a190b933eb35f2743f014878aa3f8293500e06b4907ebbd
2 parents 98ebe78 + fad21a1 commit e478b11

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

test/config.ini.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
[environment]
99
PACKAGE_NAME=@PACKAGE_NAME@
10+
PACKAGE_BUGREPORT=@PACKAGE_BUGREPORT@
1011
SRCDIR=@abs_top_srcdir@
1112
BUILDDIR=@abs_top_builddir@
1213
EXEEXT=@EXEEXT@

test/functional/test_framework/test_framework.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,12 @@ def shutdown(self):
290290
exit_code = TEST_EXIT_SKIPPED
291291
else:
292292
self.log.error("Test failed. Test logging available at %s/test_framework.log", self.options.tmpdir)
293+
self.log.error("")
293294
self.log.error("Hint: Call {} '{}' to consolidate all logs".format(os.path.normpath(os.path.dirname(os.path.realpath(__file__)) + "/../combine_logs.py"), self.options.tmpdir))
295+
self.log.error("")
296+
self.log.error("If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.")
297+
self.log.error(self.config['environment']['PACKAGE_BUGREPORT'])
298+
self.log.error("")
294299
exit_code = TEST_EXIT_FAILED
295300
# Logging.shutdown will not remove stream- and filehandlers, so we must
296301
# do it explicitly. Handlers are removed so the next test run can apply

0 commit comments

Comments
 (0)