Skip to content

Commit e5f3e95

Browse files
committed
doc: fix getchaintxstats fields in release-process.md
also: - use the getblockheader (and getblockhash) RPCs instead of getblockchaininfo for updating the nMinimumChainWork and defaultAssumeValid consensus params - use "RPC" consistently - update the example PR from 17002 to 20263 - improve a link with a named anchor tag
1 parent 42b66a6 commit e5f3e95

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

doc/release-process.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ Release Process
2727
#### Before branch-off
2828

2929
* Update hardcoded [seeds](/contrib/seeds/README.md), see [this pull request](https://github.com/bitcoin/bitcoin/pull/7415) for an example.
30-
* Update [`src/chainparams.cpp`](/src/chainparams.cpp) m_assumed_blockchain_size and m_assumed_chain_state_size with the current size plus some overhead (see [this](#how-to-calculate-m_assumed_blockchain_size-and-m_assumed_chain_state_size) for information on how to calculate them).
31-
* Update `src/chainparams.cpp` chainTxData with statistics about the transaction count and rate. Use the output of the RPC `getchaintxstats`, see
32-
[this pull request](https://github.com/bitcoin/bitcoin/pull/17002) for an example. Reviewers can verify the results by running `getchaintxstats <window_block_count> <window_last_block_hash>` with the `window_block_count` and `window_last_block_hash` from your output.
33-
* Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
34-
* Update `src/chainparams.cpp` defaultAssumeValid with information from the getblockhash rpc.
30+
* Update [`src/chainparams.cpp`](/src/chainparams.cpp) m_assumed_blockchain_size and m_assumed_chain_state_size with the current size plus some overhead (see [this](#how-to-calculate-assumed-blockchain-and-chain-state-size) for information on how to calculate them).
31+
* Update [`src/chainparams.cpp`](/src/chainparams.cpp) chainTxData with statistics about the transaction count and rate. Use the output of the `getchaintxstats` RPC, see
32+
[this pull request](https://github.com/bitcoin/bitcoin/pull/20263) for an example. Reviewers can verify the results by running `getchaintxstats <window_block_count> <window_final_block_hash>` with the `window_block_count` and `window_final_block_hash` from your output.
33+
* Update `src/chainparams.cpp` nMinimumChainWork and defaultAssumeValid (and the block height comment) with information from the `getblockheader` (and `getblockhash`) RPCs.
3534
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
3635
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
3736
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
@@ -371,7 +370,7 @@ bitcoin.org (see below for bitcoin.org update instructions).
371370

372371
### Additional information
373372

374-
#### How to calculate `m_assumed_blockchain_size` and `m_assumed_chain_state_size`
373+
#### <a name="how-to-calculate-assumed-blockchain-and-chain-state-size"></a>How to calculate `m_assumed_blockchain_size` and `m_assumed_chain_state_size`
375374

376375
Both variables are used as a guideline for how much space the user needs on their drive in total, not just strictly for the blockchain.
377376
Note that all values should be taken from a **fully synced** node and have an overhead of 5-10% added on top of its base value.

0 commit comments

Comments
 (0)