test: remove redundant two-way disconnect_nodes calls

Author: robot-visions

test/functional/p2p_node_network_limited.py

@@ -42,9 +42,6 @@ def set_test_params(self):
 
     def disconnect_all(self):
         disconnect_nodes(self.nodes[0], 1)
-        disconnect_nodes(self.nodes[1], 0)
-        disconnect_nodes(self.nodes[2], 1)
-        disconnect_nodes(self.nodes[2], 0)
         disconnect_nodes(self.nodes[0], 2)
         disconnect_nodes(self.nodes[1], 2)
 

test/functional/rpc_psbt.py

@@ -44,9 +44,7 @@ def test_utxo_conversion(self):
 
         # Disconnect offline node from others
         disconnect_nodes(offline_node, 1)
-        disconnect_nodes(online_node, 0)
         disconnect_nodes(offline_node, 2)
-        disconnect_nodes(mining_node, 0)
 
         # Create watchonly on online_node
         online_node.createwallet(wallet_name='wonline', disable_private_keys=True)

test/functional/test_framework/test_framework.py

@@ -508,7 +508,6 @@ def split_network(self):
         Split the network of four nodes into nodes 0/1 and 2/3.
         """
         disconnect_nodes(self.nodes[1], 2)
-        disconnect_nodes(self.nodes[2], 1)
         self.sync_all(self.nodes[:2])
         self.sync_all(self.nodes[2:])
 

test/functional/wallet_txn_clone.py

@@ -31,7 +31,6 @@ def setup_network(self):
         # Start with split network:
         super().setup_network()
         disconnect_nodes(self.nodes[1], 2)
-        disconnect_nodes(self.nodes[2], 1)
 
     def run_test(self):
         if self.options.segwit:

test/functional/wallet_txn_doublespend.py

@@ -29,7 +29,6 @@ def setup_network(self):
         # Start with split network:
         super().setup_network()
         disconnect_nodes(self.nodes[1], 2)
-        disconnect_nodes(self.nodes[2], 1)
 
     def run_test(self):
         # All nodes should start with 1,250 BTC: