Skip to content

Commit e75d227

Browse files
committed
Minor fix: Don't directly delete abandoned txes
This fully closes bitcoin#12179. Currently, in the GUI, when a user abandons a transaction, a call is made to remove it from the list, and another signal fires (eventually) that adds it back to the GUI with a trash can icon. There are no conditions where the abandoned transaction should be directly removed from the GUI. If the underlying model changes, the deletion will be reflected anyway.
1 parent 48174c0 commit e75d227

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/qt/transactionview.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,6 @@ void TransactionView::abandonTx()
421421

422422
// Abandon the wallet transaction over the walletModel
423423
model->wallet().abandonTransaction(hash);
424-
425-
// Update the table
426-
model->getTransactionTableModel()->updateTransaction(hashQStr, CT_UPDATED, false);
427424
}
428425

429426
void TransactionView::bumpFee([[maybe_unused]] bool checked)

0 commit comments

Comments
 (0)