Merge #13546: wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...)

MarcoFalke · MarcoFalke · commit e798ae41e0f0 · 2018-09-24T07:37:18.000-04:00
a23a7f6 wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) (practicalswift) Pull request description: Avoid use of uninitialized value `bnb_used` in `CWallet::CreateTransaction(...)`. Tree-SHA512: 22faf0711ae35af44d9a0ab7f251bc01661ac88b40ad7b0a87a510427b46bbc8caf16868cab2e0a05e7d8518e93ce666d6bd1d48d3707d37bab2c0fb56a0a4a2
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2743,6 +2743,8 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CTransac
                             return false;
                         }
                     }
+                } else {
+                    bnb_used = false;
                 }
 
                 const CAmount nChange = nValueIn - nValueToSelect;

Original file line number	Diff line number	Diff line change
`@@ -2743,6 +2743,8 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CTransac`
`2743`	`2743`	`return false;`
`2744`	`2744`	`}`
`2745`	`2745`	`}`
	`2746`	`+ } else {`
	`2747`	`+ bnb_used = false;`
`2746`	`2748`	`}`
`2747`	`2749`
`2748`	`2750`	`const CAmount nChange = nValueIn - nValueToSelect;`