Skip to content

Commit eb180d8

Browse files
author
merge-script
committed
Merge bitcoin/bitcoin#23050: log: change an incorrect fee to fee rate, and vice-versa
c17f554 Fix BlockAssembler::AddToBlock, CTxMemPool::PrioritiseTransaction logging (Jon Atack) Pull request description: This is a tale of two fees, er, fee rates... indeed, one is misdescribed as a fee, and the other is incorrectly called a fee rate. From this review discussion: bitcoin/bitcoin#22689 (comment) (thanks to John Newbery). ACKs for top commit: laanwj: Code review ACK c17f554 Tree-SHA512: 3d9df3209a72562c5f9bbf815923d5b089d04491b8d19caa2c04158c501b47ef01e47f1c32d89adcbaf3c6357329507f65b4bb2963214c3451bbfa61ac812530
2 parents 1260b7e + c17f554 commit eb180d8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/miner.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ void BlockAssembler::AddToBlock(CTxMemPool::txiter iter)
237237

238238
bool fPrintPriority = gArgs.GetBoolArg("-printpriority", DEFAULT_PRINTPRIORITY);
239239
if (fPrintPriority) {
240-
LogPrintf("fee %s txid %s\n",
240+
LogPrintf("fee rate %s txid %s\n",
241241
CFeeRate(iter->GetModifiedFee(), iter->GetTxSize()).ToString(),
242242
iter->GetTx().GetHash().ToString());
243243
}

src/txmempool.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -924,7 +924,7 @@ void CTxMemPool::PrioritiseTransaction(const uint256& hash, const CAmount& nFeeD
924924
++nTransactionsUpdated;
925925
}
926926
}
927-
LogPrintf("PrioritiseTransaction: %s feerate += %s\n", hash.ToString(), FormatMoney(nFeeDelta));
927+
LogPrintf("PrioritiseTransaction: %s fee += %s\n", hash.ToString(), FormatMoney(nFeeDelta));
928928
}
929929

930930
void CTxMemPool::ApplyDelta(const uint256& hash, CAmount &nFeeDelta) const

0 commit comments

Comments
 (0)