Skip to content

Commit eb4df9a

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#22004: fuzz: Speed up transaction fuzz target
bbbb518 fuzz: Speed up transaction fuzz target (MarcoFalke) Pull request description: `hashBlock` and `include_addresses` are orthogonal, so no need to do an exhaustive "search". Might fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34491 ACKs for top commit: practicalswift: cr ACK bbbb518: patch looks correct, and `TxToUniv` surprisingly wide in the `transaction_fuzz_target` flame graph! Putting it on a diet makes sense. Tree-SHA512: 1e7c30c7fecf96364a9a1597c0a22139389fdeb67db59f3c2c6fc088196e3332877b2865991a957980d542f99a2f48cc066dd7cc16c695a5113190fe06205089
2 parents ac5f7f4 + bbbb518 commit eb4df9a

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/test/fuzz/transaction.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ FUZZ_TARGET_INIT(transaction, initialize_transaction)
103103
(void)IsWitnessStandard(tx, coins_view_cache);
104104

105105
UniValue u(UniValue::VOBJ);
106-
TxToUniv(tx, /* hashBlock */ {}, /* include_addresses */ true, u);
107-
TxToUniv(tx, /* hashBlock */ {}, /* include_addresses */ false, u);
108-
static const uint256 u256_max(uint256S("ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"));
109-
TxToUniv(tx, u256_max, /* include_addresses */ true, u);
110-
TxToUniv(tx, u256_max, /* include_addresses */ false, u);
106+
TxToUniv(tx, /* hashBlock */ uint256::ZERO, /* include_addresses */ true, u);
107+
TxToUniv(tx, /* hashBlock */ uint256::ONE, /* include_addresses */ false, u);
111108
}

0 commit comments

Comments
 (0)