refactor: Avoid recursive locking in CAddrMan::size

hebasto · hebasto · commit efc6fac951e7 · 2021-06-14T17:21:28.000+03:00
diff --git a/src/addrman.cpp b/src/addrman.cpp
@@ -362,7 +362,7 @@ void CAddrMan::Attempt_(const CService& addr, bool fCountFailure, int64_t nTime)
 
 CAddrInfo CAddrMan::Select_(bool newOnly)
 {
-    if (size() == 0)
+    if (vRandom.empty())
         return CAddrInfo();
 
     if (newOnly && nNew == 0)

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ void CAddrMan::Attempt_(const CService& addr, bool fCountFailure, int64_t nTime)`
`362`	`362`
`363`	`363`	`CAddrInfo CAddrMan::Select_(bool newOnly)`
`364`	`364`	`{`
`365`		`- if (size() == 0)`
	`365`	`+ if (vRandom.empty())`
`366`	`366`	`return CAddrInfo();`
`367`	`367`
`368`	`368`	`if (newOnly && nNew == 0)`