Skip to content

Commit f4254e2

Browse files
committed
assume duplicate transactions are not added to iters_by_txid
In `AddTransactionsToBlock` description comment we have the asuumption that callers will never pass multiple transactions with the same txid We are asserting to assume that does not happen.
1 parent 29eb219 commit f4254e2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/kernel/disconnected_transactions.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ size_t DisconnectedBlockTransactions::DynamicMemoryUsage() const
5151
iters_by_txid.reserve(iters_by_txid.size() + vtx.size());
5252
for (auto block_it = vtx.rbegin(); block_it != vtx.rend(); ++block_it) {
5353
auto it = queuedTx.insert(queuedTx.end(), *block_it);
54-
iters_by_txid.emplace((*block_it)->GetHash(), it);
54+
auto [_, inserted] = iters_by_txid.emplace((*block_it)->GetHash(), it);
55+
assert(inserted); // callers may never pass multiple transactions with the same txid
5556
cachedInnerUsage += RecursiveDynamicUsage(**block_it);
5657
}
5758
return LimitMemoryUsage();

0 commit comments

Comments
 (0)