Skip to content

Commit f52fafc

Browse files
committed
build: Drop pointless sed commands
Strings that contain moc and rcc versions without timestamps cannot cause any non-determinism.
1 parent 585cbe2 commit f52fafc

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/Makefile.qt.include

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -360,14 +360,12 @@ translate: $(srcdir)/qt/bitcoinstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCO
360360
$(QT_QRC_LOCALE_CPP): $(QT_QRC_LOCALE) $(QT_QM)
361361
@test -f $(RCC)
362362
@cp -f $< $(@D)/temp_$(<F)
363-
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(RCC) -name bitcoin_locale $(@D)/temp_$(<F) | \
364-
$(SED) -e '/^\*\*.*Created:/d' -e '/^\*\*.*by:/d' > $@
363+
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(RCC) -name bitcoin_locale $(@D)/temp_$(<F) > $@
365364
@rm $(@D)/temp_$(<F)
366365

367366
$(QT_QRC_CPP): $(QT_QRC) $(QT_FORMS_H) $(RES_FONTS) $(RES_ICONS) $(RES_ANIMATION)
368367
@test -f $(RCC)
369-
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(RCC) -name bitcoin $< | \
370-
$(SED) -e '/^\*\*.*Created:/d' -e '/^\*\*.*by:/d' > $@
368+
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(RCC) -name bitcoin $< > $@
371369

372370
CLEAN_QT = $(nodist_qt_libbitcoinqt_a_SOURCES) $(QT_QM) $(QT_FORMS_H) qt/*.gcda qt/*.gcno qt/temp_bitcoin_locale.qrc
373371

@@ -398,12 +396,10 @@ ui_%.h: %.ui
398396
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(UIC) -o $@ $< || (echo "Error creating $@"; false)
399397

400398
%.moc: %.cpp
401-
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< | \
402-
$(SED) -e '/^\*\*.*Created:/d' -e '/^\*\*.*by:/d' > $@
399+
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< > $@
403400

404401
moc_%.cpp: %.h
405-
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< | \
406-
$(SED) -e '/^\*\*.*Created:/d' -e '/^\*\*.*by:/d' > $@
402+
$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< > $@
407403

408404
%.qm: %.ts
409405
@test -f $(LRELEASE)

0 commit comments

Comments
 (0)