Skip to content

Commit f59e915

Browse files
author
MacroFake
committed
Merge bitcoin/bitcoin#26131: log: log RPC port on startup
9d14f27 log: log RPC port on startup (James O'Beirne) Pull request description: I just spent a few hours trying to figure out why "18444" wasn't getting me to regtest's RPC server. I'm not the sharpest tool in the shed, but I was maybe understandably confused because "Bound to 127.0.0.1:18445" appears in the logs, which I assumed was the P2P port. This change logs the RPC listening address by default on startup, which seems like a basic piece of information that shouldn't be buried under `-debug`. ACKs for top commit: dergoegge: ACK 9d14f27 jarolrod: ACK 9d14f27 aureleoules: ACK 9d14f27 Tree-SHA512: 5c86f018c0b8d6264abf878c921afe53033b23ab4cf289276bb1ed28fdf591c9d8871a4baa4098c363cb2aa9a637d2e4e18e56b14dfc7d767ee40757d7ff2e7c
2 parents 33eef56 + 9d14f27 commit f59e915

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/httpserver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ static bool HTTPBindAddresses(struct evhttp* http)
320320

321321
// Bind addresses
322322
for (std::vector<std::pair<std::string, uint16_t> >::iterator i = endpoints.begin(); i != endpoints.end(); ++i) {
323-
LogPrint(BCLog::HTTP, "Binding RPC on address %s port %i\n", i->first, i->second);
323+
LogPrintf("Binding RPC on address %s port %i\n", i->first, i->second);
324324
evhttp_bound_socket *bind_handle = evhttp_bind_socket_with_handle(http, i->first.empty() ? nullptr : i->first.c_str(), i->second);
325325
if (bind_handle) {
326326
CNetAddr addr;

0 commit comments

Comments
 (0)