refactor: Fix CAddrMan::Check style

hebasto · hebasto · commit f77d9c79aa41 · 2021-06-14T17:28:36.000+03:00
This change improves readability, and follows Developer Notes.
diff --git a/src/addrman.h b/src/addrman.h
@@ -716,11 +716,10 @@ class CAddrMan
     void Check()
     {
 #ifdef DEBUG_ADDRMAN
-        {
-            LOCK(cs);
-            int err;
-            if ((err=Check_()))
-                LogPrintf("ADDRMAN CONSISTENCY CHECK FAILED!!! err=%i\n", err);
+        LOCK(cs);
+        const int err = Check_();
+        if (err) {
+            LogPrintf("ADDRMAN CONSISTENCY CHECK FAILED!!! err=%i\n", err);
         }
 #endif
     }

Original file line number	Diff line number	Diff line change
`@@ -716,11 +716,10 @@ class CAddrMan`
`716`	`716`	`void Check()`
`717`	`717`	`{`
`718`	`718`	`#ifdef DEBUG_ADDRMAN`
`719`		`- {`
`720`		`- LOCK(cs);`
`721`		`- int err;`
`722`		`- if ((err=Check_()))`
`723`		`- LogPrintf("ADDRMAN CONSISTENCY CHECK FAILED!!! err=%i\n", err);`
	`719`	`+ LOCK(cs);`
	`720`	`+ const int err = Check_();`
	`721`	`+ if (err) {`
	`722`	`+ LogPrintf("ADDRMAN CONSISTENCY CHECK FAILED!!! err=%i\n", err);`
`724`	`723`	`}`
`725`	`724`	`#endif`
`726`	`725`	`}`