Skip to content

Commit f95bbf5

Browse files
committed
misc package validation doc improvements
1 parent 3308c61 commit f95bbf5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/rpc/rawtransaction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,7 @@ static RPCHelpMan testmempoolaccept()
903903
RPCResult{
904904
RPCResult::Type::ARR, "", "The result of the mempool acceptance test for each raw transaction in the input array.\n"
905905
"Returns results for each transaction in the same order they were passed in.\n"
906-
"It is possible for transactions to not be fully validated ('allowed' unset) if another transaction failed.\n",
906+
"Transactions that cannot be fully validated due to failures in other transactions will not contain an 'allowed' result.\n",
907907
{
908908
{RPCResult::Type::OBJ, "", "",
909909
{

src/validation.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ struct PackageMempoolAcceptResult
199199
/**
200200
* Map from wtxid to finished MempoolAcceptResults. The client is responsible
201201
* for keeping track of the transaction objects themselves. If a result is not
202-
* present, it means validation was unfinished for that transaction.
202+
* present, it means validation was unfinished for that transaction. If there
203+
* was a package-wide error (see result in m_state), m_tx_results will be empty.
203204
*/
204205
std::map<const uint256, const MempoolAcceptResult> m_tx_results;
205206

@@ -227,7 +228,8 @@ MempoolAcceptResult AcceptToMemoryPool(CChainState& active_chainstate, CTxMemPoo
227228
* @param[in] txns Group of transactions which may be independent or contain
228229
* parent-child dependencies. The transactions must not conflict
229230
* with each other, i.e., must not spend the same inputs. If any
230-
* dependencies exist, parents must appear before children.
231+
* dependencies exist, parents must appear anywhere in the list
232+
* before their children.
231233
* @returns a PackageMempoolAcceptResult which includes a MempoolAcceptResult for each transaction.
232234
* If a transaction fails, validation will exit early and some results may be missing.
233235
*/

0 commit comments

Comments
 (0)