Skip to content

Commit fa03713

Browse files
author
MarcoFalke
committed
test: Properly raise FailedToStartError when rpc shutdown before warmup finished (take 2)
1 parent 4702cad commit fa03713

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/functional/test_framework/test_node.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,6 @@ def wait_for_rpc_connection(self):
225225
self.rpc_connected = True
226226
self.url = self.rpc.url
227227
return
228-
except IOError as e:
229-
if e.errno != errno.ECONNREFUSED: # Port not yet open?
230-
raise # unknown IO error
231228
except JSONRPCException as e: # Initialization phase
232229
# -28 RPC in warmup
233230
# -342 Service unavailable, RPC server started but is shutting down due to error
@@ -237,6 +234,9 @@ def wait_for_rpc_connection(self):
237234
# This might happen when the RPC server is in warmup, but shut down before the call to getblockcount
238235
# succeeds. Try again to properly raise the FailedToStartError
239236
pass
237+
except OSError as e:
238+
if e.errno != errno.ECONNREFUSED: # Port not yet open?
239+
raise # unknown OS error
240240
except ValueError as e: # cookie file not found and no rpcuser or rpcassword. bitcoind still starting
241241
if "No RPC credentials" not in str(e):
242242
raise

0 commit comments

Comments
 (0)