Skip to content

Commit fa1571b

Browse files
author
MarcoFalke
committed
doc: Add missing optional to MempoolEntryDescription
1 parent 4fd0ce7 commit fa1571b

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/rpc/blockchain.cpp

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,16 +464,23 @@ static RPCHelpMan getdifficulty()
464464
static std::vector<RPCResult> MempoolEntryDescription() { return {
465465
RPCResult{RPCResult::Type::NUM, "vsize", "virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted."},
466466
RPCResult{RPCResult::Type::NUM, "weight", "transaction weight as defined in BIP 141."},
467-
RPCResult{RPCResult::Type::STR_AMOUNT, "fee", "transaction fee, denominated in " + CURRENCY_UNIT + " (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
468-
RPCResult{RPCResult::Type::STR_AMOUNT, "modifiedfee", "transaction fee with fee deltas used for mining priority, denominated in " + CURRENCY_UNIT + " (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
467+
RPCResult{RPCResult::Type::STR_AMOUNT, "fee", /*optional=*/true,
468+
"transaction fee, denominated in " + CURRENCY_UNIT + " (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
469+
RPCResult{RPCResult::Type::STR_AMOUNT, "modifiedfee", /*optional=*/true,
470+
"transaction fee with fee deltas used for mining priority, denominated in " + CURRENCY_UNIT +
471+
" (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
469472
RPCResult{RPCResult::Type::NUM_TIME, "time", "local time transaction entered pool in seconds since 1 Jan 1970 GMT"},
470473
RPCResult{RPCResult::Type::NUM, "height", "block height when transaction entered pool"},
471474
RPCResult{RPCResult::Type::NUM, "descendantcount", "number of in-mempool descendant transactions (including this one)"},
472475
RPCResult{RPCResult::Type::NUM, "descendantsize", "virtual transaction size of in-mempool descendants (including this one)"},
473-
RPCResult{RPCResult::Type::STR_AMOUNT, "descendantfees", "transaction fees of in-mempool descendants (including this one) with fee deltas used for mining priority, denominated in " + CURRENCY_ATOM + "s (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
476+
RPCResult{RPCResult::Type::STR_AMOUNT, "descendantfees", /*optional=*/true,
477+
"transaction fees of in-mempool descendants (including this one) with fee deltas used for mining priority, denominated in " +
478+
CURRENCY_ATOM + "s (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
474479
RPCResult{RPCResult::Type::NUM, "ancestorcount", "number of in-mempool ancestor transactions (including this one)"},
475480
RPCResult{RPCResult::Type::NUM, "ancestorsize", "virtual transaction size of in-mempool ancestors (including this one)"},
476-
RPCResult{RPCResult::Type::STR_AMOUNT, "ancestorfees", "transaction fees of in-mempool ancestors (including this one) with fee deltas used for mining priority, denominated in " + CURRENCY_ATOM + "s (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
481+
RPCResult{RPCResult::Type::STR_AMOUNT, "ancestorfees", /*optional=*/true,
482+
"transaction fees of in-mempool ancestors (including this one) with fee deltas used for mining priority, denominated in " +
483+
CURRENCY_ATOM + "s (DEPRECATED, returned only if config option -deprecatedrpc=fees is passed)"},
477484
RPCResult{RPCResult::Type::STR_HEX, "wtxid", "hash of serialized transaction, including witness data"},
478485
RPCResult{RPCResult::Type::OBJ, "fees", "",
479486
{

0 commit comments

Comments
 (0)