Add missing GUARDED_BY to CAddrMan::insecure_rand

Author: MarcoFalke

src/addrman.h

@@ -631,12 +631,12 @@ class CAddrMan
     uint256 nKey;
 
     //! Source of random numbers for randomization in inner loops
-    mutable FastRandomContext insecure_rand;
+    mutable FastRandomContext insecure_rand GUARDED_BY(cs);
 
-private:
     //! A mutex to protect the inner data structures.
     mutable Mutex cs;
 
+private:
     //! Serialization versions.
     enum Format : uint8_t {
         V0_HISTORICAL = 0,    //!< historic format, before commit e6b343d88

src/test/addrman_tests.cpp

@@ -34,6 +34,7 @@ class CAddrManTest : public CAddrMan
     //! Ensure that bucket placement is always the same for testing purposes.
     void MakeDeterministic()
     {
+        LOCK(cs);
         nKey.SetNull();
         insecure_rand = FastRandomContext(true);
     }
@@ -87,11 +88,11 @@ class CAddrManTest : public CAddrMan
     {
         CAddrMan::Clear();
         if (deterministic) {
+            LOCK(cs);
             nKey.SetNull();
             insecure_rand = FastRandomContext(true);
         }
     }
-
 };
 
 static CNetAddr ResolveIP(const std::string& ip)

src/test/fuzz/addrman.cpp

@@ -27,7 +27,7 @@ class CAddrManDeterministic : public CAddrMan
 public:
     void MakeDeterministic(const uint256& random_seed)
     {
-        insecure_rand = FastRandomContext{random_seed};
+        WITH_LOCK(cs, insecure_rand = FastRandomContext{random_seed});
         Clear();
     }
 };

src/test/net_tests.cpp

@@ -37,6 +37,7 @@ class CAddrManSerializationMock : public CAddrMan
     //! Ensure that bucket placement is always the same for testing purposes.
     void MakeDeterministic()
     {
+        LOCK(cs);
         nKey.SetNull();
         insecure_rand = FastRandomContext(true);
     }