Skip to content

Commit fa3fa27

Browse files
author
MarcoFalke
committed
fuzz: Remove option --export_coverage from test_runner
The coverage statistics are not stable across clang versions
1 parent aaaa055 commit fa3fa27

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

test/fuzz/test_runner.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ def main():
2929
default="INFO",
3030
help="log events at this level and higher to the console. Can be set to DEBUG, INFO, WARNING, ERROR or CRITICAL. Passing --loglevel DEBUG will output all logs to console.",
3131
)
32-
parser.add_argument(
33-
'--export_coverage',
34-
action='store_true',
35-
help='If true, export coverage information to files in the seed corpus',
36-
)
3732
parser.add_argument(
3833
'--valgrind',
3934
action='store_true',
@@ -131,7 +126,6 @@ def main():
131126
corpus=args.seed_dir,
132127
test_list=test_list_selection,
133128
build_dir=config["environment"]["BUILDDIR"],
134-
export_coverage=args.export_coverage,
135129
use_valgrind=args.valgrind,
136130
)
137131

@@ -152,7 +146,7 @@ def merge_inputs(*, corpus, test_list, build_dir, merge_dir):
152146
logging.debug('Output: {}'.format(output))
153147

154148

155-
def run_once(*, corpus, test_list, build_dir, export_coverage, use_valgrind):
149+
def run_once(*, corpus, test_list, build_dir, use_valgrind):
156150
for t in test_list:
157151
corpus_path = os.path.join(corpus, t)
158152
if t in FUZZERS_MISSING_CORPORA:
@@ -177,13 +171,6 @@ def run_once(*, corpus, test_list, build_dir, export_coverage, use_valgrind):
177171
logging.info(e.stderr)
178172
logging.info("Target \"{}\" failed with exit code {}: {}".format(t, e.returncode, " ".join(args)))
179173
sys.exit(1)
180-
if not export_coverage:
181-
continue
182-
for l in output.splitlines():
183-
if 'INITED' in l:
184-
with open(os.path.join(corpus, t + '_coverage'), 'w', encoding='utf-8') as cov_file:
185-
cov_file.write(l)
186-
break
187174

188175

189176
def parse_test_list(makefile):

0 commit comments

Comments
 (0)