rpc: Simplify GetAllOutputTypes with the Join helper

MarcoFalke · MarcoFalke · commit fa41c657022b · 2020-06-21T06:40:18.000-04:00
This commit does not change behavior
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -511,12 +511,11 @@ static UniValue decoderawtransaction(const JSONRPCRequest& request)
 
 static std::string GetAllOutputTypes()
 {
-    std::string ret;
+    std::vector<std::string> ret;
     for (int i = TX_NONSTANDARD; i <= TX_WITNESS_UNKNOWN; ++i) {
-        if (i != TX_NONSTANDARD) ret += ", ";
-        ret += GetTxnOutputType(static_cast<txnouttype>(i));
+        ret.emplace_back(GetTxnOutputType(static_cast<txnouttype>(i)));
     }
-    return ret;
+    return Join(ret, ", ");
 }
 
 static UniValue decodescript(const JSONRPCRequest& request)

Original file line number	Diff line number	Diff line change
`@@ -511,12 +511,11 @@ static UniValue decoderawtransaction(const JSONRPCRequest& request)`
`511`	`511`
`512`	`512`	`static std::string GetAllOutputTypes()`
`513`	`513`	`{`
`514`		`- std::string ret;`
	`514`	`+ std::vector<std::string> ret;`
`515`	`515`	`for (int i = TX_NONSTANDARD; i <= TX_WITNESS_UNKNOWN; ++i) {`
`516`		`- if (i != TX_NONSTANDARD) ret += ", ";`
`517`		`- ret += GetTxnOutputType(static_cast<txnouttype>(i));`
	`516`	`+ ret.emplace_back(GetTxnOutputType(static_cast<txnouttype>(i)));`
`518`	`517`	`}`
`519`		`- return ret;`
	`518`	`+ return Join(ret, ", ");`
`520`	`519`	`}`
`521`	`520`
`522`	`521`	`static UniValue decodescript(const JSONRPCRequest& request)`