Skip to content

Commit fa42da2

Browse files
author
MarcoFalke
committed
fuzz: Use ConsumeNode in process_message target
1 parent fa121f0 commit fa42da2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/test/fuzz/process_message.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <streams.h>
1414
#include <test/fuzz/FuzzedDataProvider.h>
1515
#include <test/fuzz/fuzz.h>
16+
#include <test/fuzz/util.h>
1617
#include <test/util/mining.h>
1718
#include <test/util/net.h>
1819
#include <test/util/setup_common.h>
@@ -63,13 +64,15 @@ void fuzz_target(const std::vector<uint8_t>& buffer, const std::string& LIMIT_TO
6364
}
6465
const bool jump_out_of_ibd{fuzzed_data_provider.ConsumeBool()};
6566
if (jump_out_of_ibd) chainstate.JumpOutOfIbd();
66-
CDataStream random_bytes_data_stream{fuzzed_data_provider.ConsumeRemainingBytes<unsigned char>(), SER_NETWORK, PROTOCOL_VERSION};
67-
CNode& p2p_node = *MakeUnique<CNode>(0, ServiceFlags(NODE_NETWORK | NODE_WITNESS | NODE_BLOOM), INVALID_SOCKET, CAddress{CService{in_addr{0x0100007f}, 7777}, NODE_NETWORK}, 0, 0, CAddress{}, std::string{}, ConnectionType::OUTBOUND_FULL_RELAY).release();
67+
CNode& p2p_node = *ConsumeNodeAsUniquePtr(fuzzed_data_provider).release();
6868
p2p_node.fSuccessfullyConnected = true;
6969
p2p_node.nVersion = PROTOCOL_VERSION;
7070
p2p_node.SetCommonVersion(PROTOCOL_VERSION);
7171
connman.AddTestNode(p2p_node);
7272
g_setup->m_node.peerman->InitializeNode(&p2p_node);
73+
74+
// fuzzed_data_provider is fully consumed after this call, don't use it
75+
CDataStream random_bytes_data_stream{fuzzed_data_provider.ConsumeRemainingBytes<unsigned char>(), SER_NETWORK, PROTOCOL_VERSION};
7376
try {
7477
g_setup->m_node.peerman->ProcessMessage(p2p_node, random_message_type, random_bytes_data_stream,
7578
GetTime<std::chrono::microseconds>(), std::atomic<bool>{false});

0 commit comments

Comments
 (0)