Skip to content

Commit fa4c599

Browse files
author
MarcoFalke
committed
rpc: Quote user supplied descriptor in error msg
1 parent 623745c commit fa4c599

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/script/descriptor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2018-2021 The Bitcoin Core developers
1+
// Copyright (c) 2018-2022 The Bitcoin Core developers
22
// Distributed under the MIT software license, see the accompanying
33
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
44

@@ -1222,7 +1222,7 @@ std::unique_ptr<DescriptorImpl> ParseScript(uint32_t& key_exp_index, Span<const
12221222
error = "A function is needed within P2WSH";
12231223
return nullptr;
12241224
}
1225-
error = strprintf("%s is not a valid descriptor function", std::string(expr.begin(), expr.end()));
1225+
error = strprintf("'%s' is not a valid descriptor function", std::string(expr.begin(), expr.end()));
12261226
return nullptr;
12271227
}
12281228

test/functional/rpc_getdescriptorinfo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python3
2-
# Copyright (c) 2019-2020 The Bitcoin Core developers
2+
# Copyright (c) 2019-2022 The Bitcoin Core developers
33
# Distributed under the MIT software license, see the accompanying
44
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
55
"""Test getdescriptorinfo RPC.
@@ -30,7 +30,7 @@ def test_desc(self, desc, isrange, issolvable, hasprivatekeys):
3030
def run_test(self):
3131
assert_raises_rpc_error(-1, 'getdescriptorinfo', self.nodes[0].getdescriptorinfo)
3232
assert_raises_rpc_error(-3, 'Expected type string', self.nodes[0].getdescriptorinfo, 1)
33-
assert_raises_rpc_error(-5, 'is not a valid descriptor function', self.nodes[0].getdescriptorinfo, '')
33+
assert_raises_rpc_error(-5, "'' is not a valid descriptor function", self.nodes[0].getdescriptorinfo, "")
3434

3535
# P2PK output with the specified public key.
3636
self.test_desc('pk(0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798)', isrange=False, issolvable=True, hasprivatekeys=False)

0 commit comments

Comments
 (0)