refactor: Use C++11 range-based for loop

MarcoFalke · MarcoFalke · commit fa73493930e3 · 2020-07-09T13:08:42.000+02:00
diff --git a/src/wallet/bdb.cpp b/src/wallet/bdb.cpp
@@ -623,8 +623,8 @@ bool BerkeleyDatabase::PeriodicFlush()
     if (!lockDb) return false;
 
     // Don't flush if any databases are in use
-    for (auto it = env->mapFileUseCount.begin() ; it != env->mapFileUseCount.end(); it++) {
-        if ((*it).second > 0) return false;
+    for (const auto& use_count : env->mapFileUseCount) {
+        if (use_count.second > 0) return false;
     }
 
     // Don't flush if there haven't been any batch writes for this database.

Original file line number	Diff line number	Diff line change
`@@ -623,8 +623,8 @@ bool BerkeleyDatabase::PeriodicFlush()`
`623`	`623`	`if (!lockDb) return false;`
`624`	`624`
`625`	`625`	`// Don't flush if any databases are in use`
`626`		`- for (auto it = env->mapFileUseCount.begin() ; it != env->mapFileUseCount.end(); it++) {`
`627`		`- if ((*it).second > 0) return false;`
	`626`	`+ for (const auto& use_count : env->mapFileUseCount) {`
	`627`	`+ if (use_count.second > 0) return false;`
`628`	`628`	`}`
`629`	`629`
`630`	`630`	`// Don't flush if there haven't been any batch writes for this database.`