refactor: Prefer clean assert over UB in coinstats

MarcoFalke · MarcoFalke · commit fa8fffebe8ac · 2021-04-04T07:37:43.000+02:00
diff --git a/src/node/coinstats.cpp b/src/node/coinstats.cpp
@@ -94,7 +94,8 @@ static bool GetUTXOStats(CCoinsView* view, BlockManager& blockman, CCoinsStats&
     {
         LOCK(cs_main);
         assert(std::addressof(g_chainman.m_blockman) == std::addressof(blockman));
-        stats.nHeight = blockman.LookupBlockIndex(stats.hashBlock)->nHeight;
+        const CBlockIndex* block = blockman.LookupBlockIndex(stats.hashBlock);
+        stats.nHeight = Assert(block)->nHeight;
     }
 
     PrepareHash(hash_obj, stats);

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,8 @@ static bool GetUTXOStats(CCoinsView* view, BlockManager& blockman, CCoinsStats&`
`94`	`94`	`{`
`95`	`95`	`LOCK(cs_main);`
`96`	`96`	`assert(std::addressof(g_chainman.m_blockman) == std::addressof(blockman));`
`97`		`- stats.nHeight = blockman.LookupBlockIndex(stats.hashBlock)->nHeight;`
	`97`	`+ const CBlockIndex* block = blockman.LookupBlockIndex(stats.hashBlock);`
	`98`	`+ stats.nHeight = Assert(block)->nHeight;`
`98`	`99`	`}`
`99`	`100`
`100`	`101`	`PrepareHash(hash_obj, stats);`