refactor: Use only one temporary buffer in CreateObfuscateKey

MarcoFalke · MarcoFalke · commit face96110933 · 2021-05-04T06:53:37.000+02:00
diff --git a/src/dbwrapper.cpp b/src/dbwrapper.cpp
@@ -220,10 +220,9 @@ const unsigned int CDBWrapper::OBFUSCATE_KEY_NUM_BYTES = 8;
  */
 std::vector<unsigned char> CDBWrapper::CreateObfuscateKey() const
 {
-    unsigned char buff[OBFUSCATE_KEY_NUM_BYTES];
-    GetRandBytes(buff, OBFUSCATE_KEY_NUM_BYTES);
-    return std::vector<unsigned char>(&buff[0], &buff[OBFUSCATE_KEY_NUM_BYTES]);
-
+    std::vector<uint8_t> ret(OBFUSCATE_KEY_NUM_BYTES);
+    GetRandBytes(ret.data(), OBFUSCATE_KEY_NUM_BYTES);
+    return ret;
 }
 
 bool CDBWrapper::IsEmpty()

Original file line number	Diff line number	Diff line change
`@@ -220,10 +220,9 @@ const unsigned int CDBWrapper::OBFUSCATE_KEY_NUM_BYTES = 8;`
`220`	`220`	`*/`
`221`	`221`	`std::vector<unsigned char> CDBWrapper::CreateObfuscateKey() const`
`222`	`222`	`{`
`223`		`- unsigned char buff[OBFUSCATE_KEY_NUM_BYTES];`
`224`		`- GetRandBytes(buff, OBFUSCATE_KEY_NUM_BYTES);`
`225`		`- return std::vector<unsigned char>(&buff[0], &buff[OBFUSCATE_KEY_NUM_BYTES]);`
`226`		`-`
	`223`	`+ std::vector<uint8_t> ret(OBFUSCATE_KEY_NUM_BYTES);`
	`224`	`+ GetRandBytes(ret.data(), OBFUSCATE_KEY_NUM_BYTES);`
	`225`	`+ return ret;`
`227`	`226`	`}`
`228`	`227`
`229`	`228`	`bool CDBWrapper::IsEmpty()`