Merge #10480: Improve commit-check-script.sh

5432fc3 Fail on commit with VERIFY SCRIPT but no scripted-diff (Pieter Wuille)

Tree-SHA512: 687b6c825f6f882f9c8e9d301bc893383710bad70216fa40b95f7e24d83a7148f9c759c3e4bd905a6cd26960829f8f6bd03106dc6c83ac312bf34ad239917018

Author: laanwj

contrib/devtools/commit-script-check.sh

@@ -20,20 +20,27 @@ RET=0
 PREV_BRANCH=`git name-rev --name-only HEAD`
 PREV_HEAD=`git rev-parse HEAD`
 for i in `git rev-list --reverse $1`; do
-    git rev-list -n 1 --pretty="%s" $i | grep -q "^scripted-diff:" || continue
-    git checkout --quiet $i^ || exit
-    SCRIPT="`git rev-list --format=%b -n1 $i | sed '/^-BEGIN VERIFY SCRIPT-$/,/^-END VERIFY SCRIPT-$/{//!b};d'`"
-    if test "x$SCRIPT" = "x"; then
-        echo "Error: missing script for: $i"
-        echo "Failed"
-        RET=1
-    else
-        echo "Running script for: $i"
-        echo "$SCRIPT"
-        eval "$SCRIPT"
-        git --no-pager diff --exit-code $i && echo "OK" || (echo "Failed"; false) || RET=1
+    if git rev-list -n 1 --pretty="%s" $i | grep -q "^scripted-diff:"; then
+        git checkout --quiet $i^ || exit
+        SCRIPT="`git rev-list --format=%b -n1 $i | sed '/^-BEGIN VERIFY SCRIPT-$/,/^-END VERIFY SCRIPT-$/{//!b};d'`"
+        if test "x$SCRIPT" = "x"; then
+            echo "Error: missing script for: $i"
+            echo "Failed"
+            RET=1
+        else
+            echo "Running script for: $i"
+            echo "$SCRIPT"
+            eval "$SCRIPT"
+            git --no-pager diff --exit-code $i && echo "OK" || (echo "Failed"; false) || RET=1
+        fi
+        git reset --quiet --hard HEAD
+     else
+        if git rev-list "--format=%b" -n1 $i | grep -q '^-\(BEGIN\|END\)[ a-zA-Z]*-$'; then
+            echo "Error: script block marker but no scripted-diff in title"
+            echo "Failed"
+            RET=1
+        fi
     fi
-    git reset --quiet --hard HEAD
 done
 git checkout --quiet $PREV_BRANCH 2>/dev/null || git checkout --quiet $PREV_HEAD
 exit $RET