Skip to content

Commit fc0da02

Browse files
author
MarcoFalke
committed
Merge #17635: ci: Add CentOS 7 build
711e044 ci: Remove trusty build (Hennadii Stepanov) 7f3ae22 ci: Add CentOS 7 build (Hennadii Stepanov) Pull request description: Arguably, CentOS is the most conservative distro of all the popular ones. Thus, it could be a good way to check the Bitcoin Core compatibility with aged dependencies. Currently, CentOS 7 has: - Berkeley DB == 4.8.30 - Boost == 1.53.0 - GCC == 4.8.5 - libevent == 2.0.21 < minimum required [2.0.22](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md), but tests passed - MiniUPnPc == 2.0 - Python == 3.6.8 - qrencode == 3.4.1 - Qt == 5.9.7 - ZeroMQ == 4.1.4 ~Please note that this PR is based on the bugfix #17634.~ Also trusty build has been removed for the following reasons: - bitcoin/bitcoin#17628 (comment): > Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently. - bitcoin/bitcoin#17635 (comment): > Our travis is currently running at its limit and this doesn't seem like it is adding a lot new coverage compared to the other builds. Close #17628 ACKs for top commit: MarcoFalke: ACK 711e044 🚠 Tree-SHA512: 614ec8394943f482a5867067f7119bffd052924a51e32ffda9a08e10c392c4a955a3539e2f8907cb65bfd9347dadf0ba62f6d1530bbc49927c347360a5a7f73c
2 parents 4ee8a58 + 711e044 commit fc0da02

File tree

4 files changed

+26
-19
lines changed

4 files changed

+26
-19
lines changed

.travis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@ jobs:
105105
FILE_ENV="./ci/test/00_setup_env_i686.sh"
106106
107107
- stage: test
108-
name: 'x86_64 Linux [GOAL: install] [bionic] [uses qt5 dev package instead of depends Qt to speed up build and avoid timeout] [unsigned char]'
108+
name: 'x86_64 Linux [GOAL: install] [CentOS 7] [no depends, only system libs]'
109109
env: >-
110-
FILE_ENV="./ci/test/00_setup_env_native_qt5.sh"
110+
FILE_ENV="./ci/test/00_setup_env_native_centos.sh"
111111
112112
- stage: test
113-
name: 'x86_64 Linux [GOAL: install] [trusty] [no functional tests, no depends, only system libs]'
113+
name: 'x86_64 Linux [GOAL: install] [bionic] [uses qt5 dev package instead of depends Qt to speed up build and avoid timeout] [unsigned char]'
114114
env: >-
115-
FILE_ENV="./ci/test/00_setup_env_native_trusty.sh"
115+
FILE_ENV="./ci/test/00_setup_env_native_qt5.sh"
116116
117117
- stage: test
118118
name: 'x86_64 Linux [GOAL: install] [xenial] [no depends, only system libs, sanitizers: thread (TSan), no wallet]'

ci/test/00_setup_env_native_centos.sh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#!/usr/bin/env bash
2+
#
3+
# Copyright (c) 2019 The Bitcoin Core developers
4+
# Distributed under the MIT software license, see the accompanying
5+
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
6+
7+
export LC_ALL=C.UTF-8
8+
9+
export DOCKER_NAME_TAG=centos:7
10+
export DOCKER_PACKAGES="gcc-c++ libtool make git python3 python36-zmq"
11+
export PACKAGES="boost-devel libevent-devel libdb4-devel libdb4-cxx-devel miniupnpc-devel zeromq-devel qt5-qtbase-devel qt5-qttools-devel qrencode-devel"
12+
export NO_DEPENDS=1
13+
export GOAL="install"
14+
export BITCOIN_CONFIG="--enable-reduce-exports"

ci/test/00_setup_env_native_trusty.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

ci/test/04_install.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
export LC_ALL=C.UTF-8
88

9+
if [[ $DOCKER_NAME_TAG == centos* ]]; then
10+
export LC_ALL=en_US.utf8
11+
fi
12+
913
if [ "$TRAVIS_OS_NAME" == "osx" ]; then
1014
set +o errexit
1115
pushd /usr/local/Homebrew || exit 1
@@ -82,7 +86,10 @@ if [ -n "$DPKG_ADD_ARCH" ]; then
8286
DOCKER_EXEC dpkg --add-architecture "$DPKG_ADD_ARCH"
8387
fi
8488

85-
if [ "$TRAVIS_OS_NAME" != "osx" ]; then
89+
if [[ $DOCKER_NAME_TAG == centos* ]]; then
90+
${CI_RETRY_EXE} DOCKER_EXEC yum -y install epel-release
91+
${CI_RETRY_EXE} DOCKER_EXEC yum -y install $DOCKER_PACKAGES $PACKAGES
92+
elif [ "$TRAVIS_OS_NAME" != "osx" ]; then
8693
${CI_RETRY_EXE} DOCKER_EXEC apt-get update
8794
${CI_RETRY_EXE} DOCKER_EXEC apt-get install --no-install-recommends --no-upgrade -y $PACKAGES $DOCKER_PACKAGES
8895
fi

0 commit comments

Comments
 (0)