Skip to content

Commit fd4ca17

Browse files
author
MarcoFalke
committed
Merge #12092: [qt] Replaces numbered place marker %2 with %1.
8a93543 Replaces numbered place marker %2 with %1. (251) Pull request description: This PR closes #12015 in which @chen610620 suggests to replace numbered place marker `%2` with `%1`. Calling member function`QString::arg()` on a `QString` object with one arbitrary numbered place marker within the range [1,99] works, because `QString::arg()` replaces the _lowest_ numbered place marker in the `QString` object it is called on. [QString::arg documentation:](http://doc.qt.io/qt-5/qstring.html#arg) > Returns a copy of this string with the lowest numbered place marker replaced by string a, i.e., %1, %2, ..., %99. I suspect that the `%2` marker is just an unfortunate typo or the remainder of a string that used to have multiple numbered place markers. This PR replaces the numbered place marker `%2` with `%1` to avoid any confusion in the future. Tree-SHA512: 0bb40cf3b9824e1eeba0a184e72358b30d20e8261e12deb287155b7cc8317ad0b0787ef1d0671325eb8bccc9e51b3037d737015749338c31cf400930840e56b6
2 parents 5691028 + 8a93543 commit fd4ca17

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/qt/sendcoinsdialog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ void SendCoinsDialog::on_sendButton_clicked()
336336
}
337337
questionString.append(tr("Total Amount %1")
338338
.arg(BitcoinUnits::formatHtmlWithUnit(model->getOptionsModel()->getDisplayUnit(), totalAmount)));
339-
questionString.append(QString("<span style='font-size:10pt;font-weight:normal;'><br />(=%2)</span>")
339+
questionString.append(QString("<span style='font-size:10pt;font-weight:normal;'><br />(=%1)</span>")
340340
.arg(alternativeUnits.join(" " + tr("or") + "<br />")));
341341

342342
questionString.append("<hr /><span>");

0 commit comments

Comments
 (0)