You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ca2c313 Use absolute FQDN for DNS seed domains (Prayank)
Pull request description:
Fixesbitcoin/bitcoin#23193 by using absolute FQDN for domains used by DNS seeds.
It improves security and should not break anything based on my research and testing. Few things about absolute FQDN are shared in https://superuser.com/questions/1467958/why-does-putting-a-dot-after-the-url-remove-login-information
Master branch:
```
DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 127.0.0.1
```
PR branch:
```
DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 159.89.108.149
```
Reviewers can follow the steps mentioned in Issue to test: bitcoin/bitcoin#23193 (comment)
ACKs for top commit:
practicalswift:
cr ACK ca2c313
laanwj:
code review ACK ca2c313
promag:
Code review ACK ca2c313.
Tree-SHA512: 9818227332282a78c45b4470c2fc80bf899ed78aed76644ebf014e0fff1b139402ea023acdea162363a478b6f6613dbf1da57e214d2240ea0f04310473f57cca
@@ -280,7 +280,7 @@ class SigNetParams : public CChainParams {
280
280
281
281
if (!args.IsArgSet("-signetchallenge")) {
282
282
bin = ParseHex("512103ad5e0edad18cb1f0fc0d28a3d4f1f3e445640337489abb10404f2d1e086be430210359ef5021964fe22d6f8e05b2463c9540ce96883fe3b278760f048f5189f2e6c452ae");
0 commit comments