Do not shadow local variable

paveljanik · paveljanik · commit ff6639b0f548 · 2016-10-20T12:31:05.000+02:00
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp
@@ -798,8 +798,8 @@ UniValue processImport(const UniValue& data) {
                     throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Pubkey must be a hex string");
                 }
 
-                std::vector<unsigned char> data(ParseHex(strPubKey));
-                CPubKey pubKey(data.begin(), data.end());
+                std::vector<unsigned char> vData(ParseHex(strPubKey));
+                CPubKey pubKey(vData.begin(), vData.end());
 
                 if (!pubKey.IsFullyValid()) {
                     throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Pubkey is not a valid public key");

Original file line number	Diff line number	Diff line change
`@@ -798,8 +798,8 @@ UniValue processImport(const UniValue& data) {`
`798`	`798`	`throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Pubkey must be a hex string");`
`799`	`799`	`}`
`800`	`800`
`801`		`- std::vector<unsigned char> data(ParseHex(strPubKey));`
`802`		`- CPubKey pubKey(data.begin(), data.end());`
	`801`	`+ std::vector<unsigned char> vData(ParseHex(strPubKey));`
	`802`	`+ CPubKey pubKey(vData.begin(), vData.end());`
`803`	`803`
`804`	`804`	`if (!pubKey.IsFullyValid()) {`
`805`	`805`	`throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Pubkey is not a valid public key");`