W37 Lib Team Call

[nondiremanuel]

📆 Tues September 12, 2023 12:00 UTC
📍 Discord General Voice Channel

Meeting Notes:

Please add comments to this issue to suggest issues and PRs to discuss.

General Discussion Items

• BDK 1.0 milestones and timeline
• BDK Review Club: Better tests for transaction conflict handling bdk#1064 can be a good candidate
• Any review begs? 🙏
• Blockers? 🪨

New Projects and Support

• Support for sending to silent payments bdk_wallet#160
• BlockId should not have a default and passing a chain tip should be an Option bdk#1107: evan is not sure it should be an option
• refactor: use set_lookahead in set_lookahead_for_all bdk#1104
• Backwards compatibility of bdk::ChangeSet data structure bdk#1103
• Implement TxGraph::map_anchor method bdk#1096
• Indexer::index_tx can have a default impl in the trait. bdk_wallet#137

Top BDK 1.0 PRs and issues

alpha.2

Recently merged:

• Add cli esplora example bdk#1040
• Remove TransactionDetails from Wallet API bdk#1048
• Implement Anchor for BlockId bdk#1069
• fix: spks_of_all_keychains() shouldn't return an infinite iterator for non-wildcard descriptors bdk#1093

Ready to be merged:

• Enhance bdk chain structures bdk#1084: needs review on the last commit

Changes requested:

• Better tests for transaction conflict handling bdk#1064 : needs some work on the commits and a further round of review

Need Review:

• Add bitcoind_rpc chain source module. bdk#1041: vlad is taking this one and adding some tests in a different PR. Needs more reviews anyway and addressing Lloyd's comments. Moved to the In Progress column for the moment
• fix(esplora): use saturating_add in update_tx_graph() bdk#1110
• Rename methods of esplora ext bdk#1070

In progress:

To Do:

alpha.3

Recently merged:

Ready to be merged:

Changes requested:

• Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028

Need Review:

• docs: fix spelling errors bdk#1086: needs some CI fixes and rebase

In progress:

• Create LocalChain with genesis block hardwired for Network bdk#1079: Lloyd needs some clarification on the API. It still needs to be started

To Do:

• Use max_weight_to_satisfy instead of max_satisfaction_weight bdk#1036: In progress in fix: remove deprecated max_satisfaction_weight bdk#1115 but probably will need more work on it
• test: consolidate esplora blocking and async test code bdk_wallet#161
• Inconsistent checking of RBF rules bdk_wallet#192
• Reintroduce descriptor data to bdk::Wallet persistence bdk#1101
• Add integration tests for electrum, esplora, bitcoind_rpc crates bdk#1094
• bdk::Wallet should have context-specific error types bdk#994
• The Wallet.is_mine() function should return K bdk#1042
• Wallet needs descriptor checksum stored & checked in DB bdk#1078

Milestone TBD:

• Document example code or add helper code for fee estimation bdk_wallet#140
• scan_without_keychain and scan's names should be inverted bdk#1112: in progress in rename scan to scan_with_keychain bdk#1117 and needs some clarifications. To be confirmed wheter it's in milestone 2 or another one
• Add RPC Wallet Example bdk#1106
• Refactor TxGraph::walk_conflicts to check for ancestors bdk_wallet#136
• Update documentation for fee_rate and fee_absolute methods in tx_builder.rs bdk#969
• Further improve unconfirmed tx conflict resolution bdk#1109
• Make bdk_chain compile with cargo version 1.48.0 bdk#987

Top Maintenance PRs and issues

Upcoming Events

• BalticHoneybadger Riga Sept 2-3
• TABConf Atlanta Sept 6-9
• BTC Azores Sept 23-24
• PlanB Lugano Oct 20-21

🌅 Future Call Notes

📜 Past Call Notes