-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
CallLive audio callLive audio call
Description
📆 Tues October 10, 2023 12:00 UTC
📍 Discord General Voice Channel
Please add comments to this issue to suggest issues and PRs to discuss.
General Discussion Items
- BDK 1.0 milestones and timeline
- BDK Review Club
- Any review begs? 🙏
- Blockers? 🪨
Top BDK 1.0 PRs and issues
alpha.2
Recently merged 🎉:
- Better tests for transaction conflict handling bdk#1064
- Add
bitcoind_rpcchain source module. bdk#1041 - fix(esplora): use saturating_add in update_tx_graph() bdk#1110: audit job failed after merge
Ready to be merged:
Changes requested:
Need Review:
- Test status of reorg tx bdk#1124: examples for rpc -> closed since already included in Add
bitcoind_rpcchain source module. bdk#1041 - fix(electrum): fixed chain sync issue bdk#1163: just added this bug fix to electrum sync. Can we squeeze it into alpha.2?
To Do:
- ci: workflows failing due to "Connection timed out" errors bdk_wallet#129: on CI -> not necessarely linked to alpha but annoying. For the moment assigned to alpha.2
-
TxGraph::direct_conflicts_of_txshould just be calleddirect_conflictsbdk#1138: related to Better tests for transaction conflict handling bdk#1064, small change -> since it's very small and good to have early, moved to alpha.2
alpha.3
Recently merged:
Ready to be merged:
Changes requested:
Need Review:
- fix(electrum): fixed chain sync issue bdk#1145: not clear if it fixes the syncing issue. Replaced by fix(electrum): fixed chain sync issue bdk#1163. We will close this PR when that one is merged
- BlockId should not have a default and passing a chain tip should be an Option #1107 bdk#1116 -> needs further review after last changes. Different approach was chosen, needs to be substituted by a new PR. The milestone will depend on the timing of the rework -> moved to beta milestone for the moment but it can be moved in the future
- rename scan to scan_with_keychain bdk#1117 -> the author is waiting for some explanation
- Further improve unconfirmed tx conflict resolution bdk#1109 -> keep in alpha.3
In progress:
- Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028: needs to be rebased after alpha.2 milestone
- fix: remove deprecated
max_satisfaction_weightbdk#1115: on hold, needs some comment from evan and/or Lloyd -> the old method has some problems but it's not clear the impact of it. Degree of complexity (and consequently milestone) needs to be discussed - Add RPC Wallet Example bdk#1106 -> important to have but okay to leave it in alpha.3
- feat: add bdk_sqlite crate implementing PersistBackend bdk#1128: another approach has to be tried
- Refactor: Migrate bdk::FeeRate to bitcoin::FeeRate bdk#1141: either someone take this over or it will be low priority for the original author (junderw) -> important to keep it since it affects the Wallet API. Not clear if it is close to end or not
To Do:
- Coinbase transaction that is not anchored in the best chain should always be filtered out bdk#1144: new bug
- Taproot PSBT finalization fails often when signing with internal key bdk#1142: new bug to be investigated before alpha.3 and then evaluate the priority
- Reintroduce descriptor data to
bdk::Walletpersistence bdk#1101 -> ongoing discussion - The Wallet.is_mine() function should return K bdk#1042
- Create LocalChain with genesis block hardwired for Network bdk#1079: Lloyd needs some clarification on the API -> needs further discussion
- test: consolidate esplora blocking and async test code bdk_wallet#161: can we move tests to beta (then if they are done before we can include them in alpha.3)? -> ok to move to beta
- Documentation of methods can be included sooner, but a review will be needed in Beta -> LaggingTimes will have a look at this and Add integration tests for electrum, esplora, bitcoind_rpc crates bdk#1094 (tests in general)
- Add integration tests for electrum, esplora, bitcoind_rpc crates bdk#1094: to be done after test: consolidate esplora blocking and async test code bdk_wallet#161 -> if we run out of time we will move it to the Beta milestone
- Way too many
clippy::allowbdk#1127 - [wallet] Consider having a higher-level method for syncing bdk#1153: new issue (see feat: add blockchain traits module with esplora_async impl bdk#1139 below)
- Rename electrum's sync/scan bdk#1154: new issue
Milestone TBD:
- fix(wallet_esplora): Gracefully handle 429s errors rust-esplora-client#59: issue originally in 1.1 version, proposal of a quick fix to fit it into beta of 1.0 -> moved to next esplora release
- feat: add blockchain traits module with esplora_async impl bdk#1139: discussion ongoing on the concept. Related to [wallet] Consider having a higher-level method for syncing bdk#1153 issue that was assigned to alpha.3
- BIP 326 Anti Fee Sniping bdk_wallet#131
- Test electrum ext bdk#979: related to 1145 (alpha.3). Should it be included?
Top Maintenance PRs and issues
0.29 version released!!! 🎉
New Projects and Support
- [chain] Consider Merging IndexedTxGraph and TxGraph into one thing bdk_wallet#130: discussion -> not too urgent, put in the Beta at the moment
- Roadmap blog post
Upcoming Events
- BTC Azores Sept 23-24
- PlanB Lugano Oct 20-21
Metadata
Metadata
Assignees
Labels
CallLive audio callLive audio call