nits and tests

Author: reez

BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift

@@ -43,7 +43,7 @@ extension BlockchainClient {
 }
 
 private class BDKService {
-    static var shared: BDKService = BDKService()
+    static let shared: BDKService = BDKService()
 
     private var balance: Balance?
     private var persister: Persister?

BDKSwiftExampleWallet/Service/BDK Service/BDKSwiftExampleWalletError.swift

@@ -15,3 +15,22 @@ enum WalletError: Error {
     case fullScanUnsupported
     case backendNotImplemented
 }
+
+extension WalletError: LocalizedError {
+    var errorDescription: String? {
+        switch self {
+        case .blockchainConfigNotFound:
+            return "Blockchain configuration not found"
+        case .dbNotFound:
+            return "Database not found"
+        case .notSigned:
+            return "Transaction not signed"
+        case .walletNotFound:
+            return "Wallet not found"
+        case .fullScanUnsupported:
+            return "Full scan is not supported by the selected blockchain client"
+        case .backendNotImplemented:
+            return "The selected blockchain backend is not yet implemented"
+        }
+    }
+}

BDKSwiftExampleWalletTests/Service/BDKSwiftExampleWalletBDKServiceTests.swift

@@ -32,5 +32,40 @@ final class BDKSwiftExampleWalletBDKServiceTests: XCTestCase {
             Transaction.mock?.transactionID
         )
     }
+    
+    func testBDKClientGetClientType() {
+        let clientType = BDKClient.mock.getClientType()
+        
+        XCTAssertEqual(clientType, .esplora)
+    }
+    
+    func testBDKClientUpdateClientType() {
+        // This test verifies that updateClientType doesn't crash with mock client
+        // In the real implementation, setting an unimplemented type would fallback to esplora
+        BDKClient.mock.updateClientType(.kyoto)
+        
+        // Verify it still returns esplora (since mock doesn't actually change)
+        let clientType = BDKClient.mock.getClientType()
+        XCTAssertEqual(clientType, .esplora)
+    }
+    
+    func testBlockchainClientTypeEnumValues() {
+        // Test that all expected client types are available
+        let allCases = BlockchainClientType.allCases
+        XCTAssertTrue(allCases.contains(.esplora))
+        XCTAssertTrue(allCases.contains(.kyoto))
+        XCTAssertTrue(allCases.contains(.electrum))
+        XCTAssertEqual(allCases.count, 3)
+    }
+    
+    func testBlockchainClientEsploraFactory() {
+        // Test that the esplora factory method works correctly
+        let testURL = "https://blockstream.info/testnet/api"
+        let client = BlockchainClient.esplora(url: testURL)
+        
+        XCTAssertEqual(client.getUrl(), testURL)
+        XCTAssertEqual(client.getType(), .esplora)
+        XCTAssertTrue(client.supportsFullScan())
+    }
 
 }