feat: expose Wallet::create_from_two_path_descriptor constructor

Author: thunderbiscuit

bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/CreatingWalletTest.kt

@@ -42,6 +42,32 @@ class CreatingWalletTest {
         )
     }
 
+    // Create a wallet with a public multipath descriptor.
+    @Test
+    fun createWalletWithMultipathDescriptor() {
+        val multipathDescriptor = Descriptor(
+            "wpkh([9a6a2580/84'/0'/0']xpub6DEzNop46vmxR49zYWFnMwmEfawSNmAMf6dLH5YKDY463twtvw1XD7ihwJRLPRGZJz799VPFzXHpZu6WdhT29WnaeuChS6aZHZPFmqczR5K/<0;1>/*)",
+            Network.BITCOIN
+        )
+
+        Wallet.createFromTwoPathDescriptor(
+            twoPathDescriptor = multipathDescriptor,
+            network = Network.BITCOIN,
+            persister = conn
+        )
+    }
+
+    // You cannot create a private multipath descriptor.
+    @Test
+    fun cannotCreatePrivateMultipathDescriptor() {
+        assertFails {
+            Descriptor(
+                descriptor = "tprv8ZgxMBicQKsPf2qfrEygW6fdYseJDDrVnDv26PH5BHdvSuG6ecCbHqLVof9yZcMoM31z9ur3tTYbSnr1WBqbGX97CbXcmp5H6qeMpyvx35B/<0;1>/*)",
+                Network.TESTNET
+            )
+        }
+    }
+
     // Descriptors do not match provided network.
     @Test
     fun failsIfDescriptorsDontMatchNetwork() {

bdk-ffi/src/wallet.rs

@@ -67,9 +67,43 @@ impl Wallet {
         })
     }
 
+    /// Build a new `Wallet` from a two-path descriptor.
+    ///
+    /// This function parses a multipath descriptor with exactly 2 paths and creates a wallet using the existing receive and change wallet creation logic.
+    ///
+    /// Multipath descriptors follow [BIP-389](https://github.com/bitcoin/bips/blob/master/bip-0389.mediawiki) and allow defining both receive and change derivation paths in a single descriptor using the <0;1> syntax.
+    ///
+    /// If you have previously created a wallet, use load instead.
+    ///
+    /// Returns an error if the descriptor is invalid or not a 2-path multipath descriptor.
+    #[uniffi::constructor(default(lookahead = 25))]
+    pub fn create_from_two_path_descriptor(
+        two_path_descriptor: Arc<Descriptor>,
+        network: Network,
+        persister: Arc<Persister>,
+        lookahead: u32,
+    ) -> Result<Self, CreateWithPersistError> {
+        let descriptor = two_path_descriptor.to_string_with_secret();
+        let mut persist_lock = persister.inner.lock().unwrap();
+        let deref = persist_lock.deref_mut();
+
+        let wallet: PersistedWallet<PersistenceType> =
+            BdkWallet::create_from_two_path_descriptor(descriptor)
+                .network(network)
+                .lookahead(lookahead)
+                .create_wallet(deref)
+                .map_err(|e| CreateWithPersistError::Persist {
+                    error_message: e.to_string(),
+                })?;
+
+        Ok(Wallet {
+            inner_mutex: Mutex::new(wallet),
+        })
+    }
+
     /// Build Wallet by loading from persistence.
-    //
-    // Note that the descriptor secret keys are not persisted to the db.
+    ///
+    /// Note that the descriptor secret keys are not persisted to the db.
     #[uniffi::constructor(default(lookahead = 25))]
     pub fn load(
         descriptor: Arc<Descriptor>,