Expose add_foreign_utxo for TxBuilder

[BitcoinZavior]

At the moment TxBuilder does not have add_foreign_utxo

https://bitcoindevkit.org/docs-rs/bdk/nightly/latest/bdk/wallet/tx_builder/struct.TxBuilder.html#method.add_foreign_utxo

It will be great to have this method exposed so that it can be used in the language and framework bindings.

There is interest from the community in using this method in apps.

Ref:
LtbLightning/bdk-flutter#63

[notmandatory]

@thunderbiscuit can you put this on the agenda for Tues call? Let's see if we can get it into the next release.

[notmandatory]

Looks like there are a few other changes needed before we can enable this function. Per @BitcoinZavior's example in LtbLightning/bdk-flutter#63 other structs and functions we're missing in bdk-ffi are:

1. psbt::Input, shouldn't need to expose internals
2. psbt::PsbtSighashType, only add to UDL?
3. Wallet::get_psbt_input
4. Descriptor::max_satisfaction_weight

Should we divide and conquer and do in multiple PRs or all in one?

[BitcoinZavior]

This comparison shows the Rust file changes: https://github.com/LtbLightning/bdk-flutter/compare/main...foreign-utxo?expand=1

This branch was made as an example for someone to use.

[notmandatory]

I went ahead and created #362 to add the Input, PsbtSighashType structs and the Wallet::get_psbt_input function. Once those are in it should be easier to finish up this PR.

EDIT: forgot about the Descriptor::max_satisfaction_weightfunction, I'll add that too.

[reez]

Looks like this is still needed potentially, here's docs https://docs.rs/bdk_wallet/latest/bdk_wallet/struct.TxBuilder.html#method.add_foreign_utxo of method

[reez]

#703 (comment)

duplicate issue but adding the text here:

Describe the enhancement

Add add_foreign_utxo to the bdk-ffi Wallet

• To be able to calculate the satisfaction_weight for known wallets, then useful would also be max_weight_to_satisfy

Use case

• Weaken common ownership heuristic: For this is is important to build cross-owner/cross-wallet PSBTs

[andreasgriffin]

@reez , @thunderbiscuit , @notmandatory : This would be an awesome feature to have, and I wanted to ask if it is achievable.

[reez]

@reez , @thunderbiscuit , @notmandatory : This would be an awesome feature to have, and I wanted to ask if it is achievable.

lemme take a look at it again this week