Add Task to run examples #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
requested changes
Aug 21, 2025
Member
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Just a few nits but otherwise this looks good!
Comment on lines
3
to
6
| plugins { | ||
| kotlin("jvm") version "2.1.10" | ||
| application | ||
| } |
Member
There was a problem hiding this comment.
I try to keep the fully qualified names for plugins when I can. This has over time also become the recommended way from Google to add plugins, because of how confusing the shortcuts can be. Here I suggest using
plugins {
id("org.jetbrains.kotlin.jvm") version "2.1.10"
id("application")
}| ```sh | ||
| bash ./scripts/build-<your-local-architecture>.sh | ||
| ``` | ||
| ## Run example files |
Member
There was a problem hiding this comment.
Markdown is very flexible, but just for consistency I try to follow the Google Style Guide for Markdown. In this case, you'd add blank spaces between your headings and text (one blank line before and one after).
ItoroD
force-pushed
the
task-for-examples
branch
from
95221ae to
c13a681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.