Skip to content

Add flag to prevent submodule update when running build scripts #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

Add flag to prevent submodule update when running build scripts #20

merged 2 commits into from
Sep 4, 2025

Conversation

@thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Sep 4, 2025

This fixes #19 and allows us to use the build scripts locally with any given version of the submodule (it would previously always revert to the committed version of the submodule when building).

You can now use the --skip-submodule-update flag to keep whatever version of bdk-ffi you have locally.

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Sep 4, 2025

This new flag allowed my local build of the examples to fail when using the latest commit on bdk-ffi.

@ItoroD
Copy link
Collaborator

ItoroD commented Sep 4, 2025 •
edited
Loading

This new flag allowed my local build of the examples to fail when using the latest commit on bdk-ffi.

Why is that?

Looking at the fix you did in this PR. Looks brilliant btw.

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Sep 4, 2025

The latest PR on bdk-ffi is the removal of a log level from Kyoto, which is a breaking change. So I was surprised when I attempted to build locally using this latest commit and everything worked fine! That's what triggered this little rabbit hole.

If you want to test the latest commit on master, not only do you need to update your submodule using just submodule-to-master, but you also need to make sure your build script doesn't try to then re-checkout the committed submodule, using bash bash ./scripts/build-windows-x86_64.sh --skip-submodule-update.

@ItoroD
Copy link
Collaborator

ItoroD commented Sep 4, 2025

The latest PR on bdk-ffi is the removal of a log level from Kyoto, which is a breaking change. So I was surprised when

Alright makes sense.

@ItoroD
Copy link
Collaborator

ItoroD commented Sep 4, 2025

ACK e920ac0

@thunderbiscuit thunderbiscuit merged commit e920ac0 into master Sep 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItoroD ItoroD ItoroD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test trigger doesn't use the latest commit on master

3 participants

@thunderbiscuit @ItoroD