Skip to content

Conversation

@thunderbiscuit
Copy link
Member

This is dependent on bitcoindevkit/bdk-ffi#835.

Once that's in I'll bump the submodule! Notice also the submodule command I added.

@thunderbiscuit thunderbiscuit force-pushed the submodule-update branch 2 times, most recently from 16a2f02 to 7a8d1bd Compare August 19, 2025 20:53
@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Aug 19, 2025

I don't know why I can't directly request a review in the UI from you @ItoroD but I'm requesting it here! haha.

@ItoroD
Copy link
Collaborator

ItoroD commented Aug 19, 2025

Nice

I don't know why I can't directly request a review in the UI from you @ItoroD but I'm requesting it here! haha.

Maybe I do not have some privileges on this repo. Also, I expected to get notification as a code owner. Looks like I wrote my own username wrong 😓😓

I am checking the PR out now

Copy link
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d0ed4d5

Tried the command as well. Works great

@thunderbiscuit thunderbiscuit merged commit cab806c into master Aug 19, 2025
2 checks passed
@thunderbiscuit thunderbiscuit deleted the submodule-update branch November 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants