refactor(chain): compute txid once for KeychainTxOutIndex::index_tx

evanlinjin · evanlinjin · commit 001703760164 · 2024-06-13T22:56:19.000+08:00
diff --git a/crates/chain/src/keychain/txout_index.rs b/crates/chain/src/keychain/txout_index.rs
@@ -154,8 +154,9 @@ impl<K: Clone + Ord + Debug> Indexer for KeychainTxOutIndex<K> {
 
     fn index_tx(&mut self, tx: &bitcoin::Transaction) -> Self::ChangeSet {
         let mut changeset = ChangeSet::<K>::default();
+        let txid = tx.compute_txid();
         for (op, txout) in tx.output.iter().enumerate() {
-            changeset.append(self.index_txout(OutPoint::new(tx.compute_txid(), op as u32), txout));
+            changeset.append(self.index_txout(OutPoint::new(txid, op as u32), txout));
         }
         changeset
     }

Original file line number	Diff line number	Diff line change
`@@ -154,8 +154,9 @@ impl<K: Clone + Ord + Debug> Indexer for KeychainTxOutIndex<K> {`
`154`	`154`
`155`	`155`	`fn index_tx(&mut self, tx: &bitcoin::Transaction) -> Self::ChangeSet {`
`156`	`156`	`let mut changeset = ChangeSet::<K>::default();`
	`157`	`+ let txid = tx.compute_txid();`
`157`	`158`	`for (op, txout) in tx.output.iter().enumerate() {`
`158`		`- changeset.append(self.index_txout(OutPoint::new(tx.compute_txid(), op as u32), txout));`
	`159`	`+ changeset.append(self.index_txout(OutPoint::new(txid, op as u32), txout));`
`159`	`160`	`}`
`160`	`161`	`changeset`
`161`	`162`	`}`