Skip to content

Commit 3885014

Browse files
committed
chore(msrv): bump MSRV to 1.85.0
- update all references to previous 1.63.0 MSRV. - update the rust-version to 1.85.0. - update the CI to not exclude bdk_electrum anymore. - update the ci/pin-msrv.sh to 1.85.0.
1 parent 877720f commit 3885014

File tree

12 files changed

+15
-53
lines changed

12 files changed

+15
-53
lines changed

.github/workflows/cont_integration.yml

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ jobs:
2828
rust:
2929
- version: ${{ needs.prepare.outputs.rust_version }}
3030
clippy: true
31-
- version: 1.63.0 # Overall MSRV
32-
- version: 1.75.0 # Specific MSRV for `bdk_electrum`
31+
- version: 1.85.0 # Overall MSRV
3332
features:
3433
- --no-default-features --features miniscript/no-std,bdk_chain/hashbrown
3534
- --all-features
@@ -46,31 +45,15 @@ jobs:
4645
profile: minimal
4746
- name: Rust Cache
4847
uses: Swatinem/[email protected]
49-
- name: Pin dependencies for 1.75
50-
if: matrix.rust.version == '1.75.0'
51-
run: |
52-
cargo update -p home --precise "0.5.9"
53-
cargo update -p native-tls --precise "0.2.13"
54-
cargo update -p idna_adapter --precise "1.1.0"
55-
cargo update -p base64ct --precise "1.6.0"
56-
cargo update -p minreq --precise "2.13.2"
57-
cargo update -p rayon --precise "1.10.0"
58-
cargo update -p rayon-core --precise "1.12.1"
59-
cargo update -p time --precise "0.3.41"
6048
- name: Pin dependencies for MSRV
61-
if: matrix.rust.version == '1.63.0'
49+
if: matrix.rust.version == '1.85.0'
6250
run: ./ci/pin-msrv.sh
6351
- name: Build + Test
6452
env:
6553
MATRIX_RUST_VERSION: ${{ matrix.rust.version }}
6654
run: |
67-
if [ $MATRIX_RUST_VERSION = '1.63.0' ]; then
68-
cargo build --workspace --exclude 'example_*' --exclude 'bdk_electrum' ${{ matrix.features }}
69-
cargo test --workspace --exclude 'example_*' --exclude 'bdk_electrum' ${{ matrix.features }}
70-
else
7155
cargo build --workspace --exclude 'example_*' ${{ matrix.features }}
7256
cargo test --workspace --exclude 'example_*' ${{ matrix.features }}
73-
fi
7457
7558
check-no-std:
7659
needs: prepare

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Every new feature should be covered by functional tests where possible.
4646
When refactoring, structure your PR to make it easy to review and don't
4747
hesitate to split it into multiple small, focused PRs.
4848

49-
The Minimum Supported Rust Version is **1.63.0** (enforced by our CI).
49+
The Minimum Supported Rust Version is **1.85.0** (enforced by our CI).
5050

5151
Commits should cover both the issue fixed and the solution's rationale.
5252
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. Commit messages follow the ["Conventional Commits 1.0.0"](https://www.conventionalcommits.org/en/v1.0.0/) to make commit histories easier to read by humans and automated tools. All commits must be [GPG signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits).

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<a href="https://github.com/bitcoindevkit/bdk/blob/master/LICENSE"><img alt="MIT or Apache-2.0 Licensed" src="https://img.shields.io/badge/license-MIT%2FApache--2.0-blue.svg"/></a>
1313
<a href="https://github.com/bitcoindevkit/bdk/actions?query=workflow%3ACI"><img alt="CI Status" src="https://github.com/bitcoindevkit/bdk/workflows/CI/badge.svg"></a>
1414
<a href="https://coveralls.io/github/bitcoindevkit/bdk?branch=master"><img src="https://coveralls.io/repos/github/bitcoindevkit/bdk/badge.svg?branch=master"/></a>
15-
<a href="https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html"><img alt="Rustc Version 1.63.0+" src="https://img.shields.io/badge/rustc-1.63.0%2B-lightgrey.svg"/></a>
15+
<a href="https://blog.rust-lang.org/2025/02/20/Rust-1.85.0/"><img alt="Rustc Version 1.85.0+" src="https://img.shields.io/badge/rustc-1.85.0%2B-lightgrey.svg"/></a>
1616
<a href="https://discord.gg/d7NkDKm"><img alt="Chat on Discord" src="https://img.shields.io/discord/753336465005608961?logo=discord"></a>
1717
</p>
1818

@@ -58,15 +58,14 @@ Fully working examples of how to use these components are in `/examples`:
5858

5959
## Minimum Supported Rust Version (MSRV)
6060

61-
The following BDK crates maintains a MSRV of 1.63.0. To build these crates with the MSRV of 1.63.0 you will need to pin dependencies by running the [`pin-msrv.sh`](./ci/pin-msrv.sh) script.
61+
The following BDK crates maintains a MSRV of 1.85.0. To build these crates with the MSRV of 1.85.0 you will need to pin dependencies by running the [`pin-msrv.sh`](./ci/pin-msrv.sh) script.
6262

6363
- `bdk_core`
6464
- `bdk_chain`
6565
- `bdk_bitcoind_rpc`
6666
- `bdk_esplora`
6767
- `bdk_file_store`
68-
69-
The MSRV of the `bdk_electrum` crate is 1.75.0.
68+
- `bdk_electrum`
7069

7170
## Just
7271

ci/pin-msrv.sh

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,4 @@ set -euo pipefail
88
# To pin deps, switch toolchain to MSRV and execute the below updates
99

1010
# cargo clean
11-
# rustup override set 1.63.0
12-
13-
cargo update -p zstd-sys --precise "2.0.8+zstd.1.5.5"
14-
cargo update -p time --precise "0.3.20"
15-
cargo update -p home --precise "0.5.5"
16-
cargo update -p proptest --precise "1.2.0"
17-
cargo update -p url --precise "2.5.0"
18-
cargo update -p tokio --precise "1.38.1"
19-
cargo update -p reqwest --precise "0.12.4"
20-
cargo update -p security-framework-sys --precise "2.11.1"
21-
cargo update -p csv --precise "1.3.0"
22-
cargo update -p unicode-width --precise "0.1.13"
23-
cargo update -p native-tls --precise "0.2.13"
24-
cargo update -p flate2 --precise "1.0.35"
25-
cargo update -p bzip2-sys --precise "0.1.12"
26-
cargo update -p ring --precise "0.17.12"
27-
cargo update -p once_cell --precise "1.20.3"
28-
cargo update -p base64ct --precise "1.6.0"
29-
cargo update -p minreq --precise "2.13.2"
30-
cargo update -p tracing-core --precise "0.1.33"
31-
cargo update -p [email protected] --precise "1.0.1"
32-
cargo update -p rayon --precise "1.10.0"
33-
cargo update -p rayon-core --precise "1.12.1"
34-
cargo update -p [email protected] --precise "0.5.10"
11+
# rustup override set 1.85.0

clippy.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
msrv="1.63.0"
1+
msrv="1.85.0"

crates/bitcoind_rpc/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bdk_bitcoind_rpc"
33
version = "0.22.0"
44
edition = "2021"
5-
rust-version = "1.63"
5+
rust-version = "1.85.0"
66
homepage = "https://bitcoindevkit.org"
77
repository = "https://github.com/bitcoindevkit/bdk"
88
documentation = "https://docs.rs/bdk_bitcoind_rpc"

crates/chain/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bdk_chain"
33
version = "0.23.2"
44
edition = "2021"
5-
rust-version = "1.63"
5+
rust-version = "1.85.0"
66
homepage = "https://bitcoindevkit.org"
77
repository = "https://github.com/bitcoindevkit/bdk"
88
documentation = "https://docs.rs/bdk_chain"

crates/core/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bdk_core"
33
version = "0.6.2"
44
edition = "2021"
5-
rust-version = "1.63"
5+
rust-version = "1.85.0"
66
homepage = "https://bitcoindevkit.org"
77
repository = "https://github.com/bitcoindevkit/bdk"
88
documentation = "https://docs.rs/bdk_core"

crates/electrum/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
name = "bdk_electrum"
33
version = "0.23.2"
44
edition = "2021"
5+
rust-version = "1.85.0"
56
homepage = "https://bitcoindevkit.org"
67
repository = "https://github.com/bitcoindevkit/bdk"
78
documentation = "https://docs.rs/bdk_electrum"

crates/esplora/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
name = "bdk_esplora"
33
version = "0.22.1"
44
edition = "2021"
5+
rust-version = "1.85.0"
56
homepage = "https://bitcoindevkit.org"
67
repository = "https://github.com/bitcoindevkit/bdk"
78
documentation = "https://docs.rs/bdk_esplora"

0 commit comments

Comments
 (0)