Skip to content

Commit 5ffad18

Browse files
committed
Merge #2061: fix(ci): backport webpki-roots pinned version and clippy fixes
c123a28 fix(electrum): clippy warnings (Leonardo Lima) 08e189f fix(example_cli): clippy warnings (Leonardo Lima) 6c43b46 fix(ci): update `webpki-roots` pinned version (Leonardo Lima) Pull request description: backport #2058 and #2043 to `release/chain-0.23.x` ### Description ### Notes to the reviewers ### Changelog notice ### Checklists #### All Submissions: * [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: ValuedMammal: ACK c123a28 notmandatory: ACK c123a28 Tree-SHA512: 74749c139e78f9e7ddb8dae655d73fb50938ff6eb7708bcb56f21bcc47faa9ddefa79b5c19251f5b95fc4bd351948caf9dcbb814d4629db8cb0a8b67f8083014
2 parents 8f281da + c123a28 commit 5ffad18

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

ci/pin-msrv.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ cargo update -p once_cell --precise "1.20.3"
2828
cargo update -p base64ct --precise "1.6.0"
2929
cargo update -p minreq --precise "2.13.2"
3030
cargo update -p tracing-core --precise "0.1.33"
31-
cargo update -p [email protected].2 --precise "1.0.1"
31+
cargo update -p [email protected].3 --precise "1.0.1"
3232
cargo update -p rayon --precise "1.10.0"
3333
cargo update -p rayon-core --precise "1.12.1"
3434
cargo update -p [email protected] --precise "0.5.10"

crates/electrum/tests/test_electrum.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ where
7171
if let Some(chain_update) = update.chain_update.clone() {
7272
let _ = chain
7373
.apply_update(chain_update)
74-
.map_err(|err| anyhow::anyhow!("LocalChain update error: {:?}", err))?;
74+
.map_err(|err| anyhow::anyhow!("LocalChain update error: {err:?}"))?;
7575
}
7676
let _ = graph.apply_update(update.tx_update.clone());
7777

examples/example_cli/src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ impl FromStr for CoinSelectionAlgo {
229229
"oldest-first" => OldestFirst,
230230
"newest-first" => NewestFirst,
231231
"bnb" => BranchAndBound,
232-
unknown => bail!("unknown coin selection algorithm '{}'", unknown),
232+
unknown => bail!("unknown coin selection algorithm '{unknown}'"),
233233
})
234234
}
235235
}
@@ -715,8 +715,8 @@ pub fn handle_commands<CS: clap::Subcommand, S: clap::Args>(
715715
_ => unimplemented!("multi xkey signer"),
716716
};
717717

718-
let _ = sign_res
719-
.map_err(|errors| anyhow::anyhow!("failed to sign PSBT {:?}", errors))?;
718+
let _ =
719+
sign_res.map_err(|errors| anyhow::anyhow!("failed to sign PSBT {errors:?}"))?;
720720

721721
let mut obj = serde_json::Map::new();
722722
obj.insert("psbt".to_string(), json!(psbt.to_string()));

0 commit comments

Comments
 (0)