Skip to content

Commit 8f38e96

Browse files
Merge #1046: Avoid pinning dependencies, use --precise in ci
ffb7c79 ci: Avoid pinning dependencies, use --precise (Daniela Brozzoni) 56b8eea ci: No need to add the llvm repository for wasm (Daniela Brozzoni) Pull request description: Fixes #1035 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: evanlinjin: ACK ffb7c79 Tree-SHA512: a2e5e0ffea87dc86e27c2f2f3550e6e6429e66f5fd8e0196e85915de5b0f14f0e4ee9d56c87b38b101eb28d86a65868054c20421f32ecd475ca73d00471e2f8d
2 parents cb626e9 + ffb7c79 commit 8f38e96

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

.github/workflows/cont_integration.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ jobs:
2727
profile: minimal
2828
- name: Rust Cache
2929
uses: Swatinem/[email protected]
30+
- name: Pin dependencies for MSRV
31+
if: matrix.rust.version == '1.57.0'
32+
run: cargo update -p log --precise "0.4.18" && cargo update -p tempfile --precise "3.6.0"
3033
- name: Build
3134
run: cargo build ${{ matrix.features }}
3235
- name: Test
@@ -71,7 +74,6 @@ jobs:
7174
uses: actions/checkout@v2
7275
# Install a recent version of clang that supports wasm32
7376
- run: wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - || exit 1
74-
- run: sudo apt-add-repository "deb http://apt.llvm.org/focal/ llvm-toolchain-focal-10 main" || exit 1
7577
- run: sudo apt-get update || exit 1
7678
- run: sudo apt-get install -y libclang-common-10-dev clang-10 libc6-dev-i386 || exit 1
7779
- name: Install Rust toolchain

README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,15 @@ Fully working examples of how to use these components are in `/example-crates`
5252
[`rust-bitcoin`]: https://github.com/rust-bitcoin/rust-bitcoin
5353
[`esplora-client`]: https://docs.rs/esplora-client/0.3.0/esplora_client/
5454
[`electrum-client`]: https://docs.rs/electrum-client/0.13.0/electrum_client/
55+
56+
## Minimum Supported Rust Version (MSRV)
57+
This library should compile with any combination of features with Rust 1.57.0.
58+
59+
To build with the MSRV you will need to pin dependencies as follows:
60+
61+
```
62+
# log 0.4.19 has MSRV 1.60.0+
63+
cargo update -p log --precise "0.4.18"
64+
# tempfile 3.7.0 has MSRV 1.63.0
65+
cargo update -p tempfile --precise "3.6.0"
66+
```

crates/bdk/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ edition = "2021"
1313
rust-version = "1.57"
1414

1515
[dependencies]
16-
log = "=0.4.18"
16+
log = "0.4"
1717
rand = "^0.8"
1818
miniscript = { version = "9", features = ["serde"], default-features = false }
1919
bitcoin = { version = "0.29", features = ["serde", "base64", "rand"], default-features = false }

0 commit comments

Comments
 (0)