Skip to content

Commit b5612f2

Browse files
committed
Merge #1247: ci: pin home dependency to 0.5.5 and check_clippy to rust stable version
e7fbc8b ci: run clippy_check with rust stable (Steve Myers) 2251b8d ci: pin home version to 0.5.5 for 1.63 MSRV (Steve Myers) Pull request description: ### Description Fixed 1.63 MSRV error by pinning `home` dependency to `0.5.5`, and `clippy` error by changing `check_clippy` job to using rust `stable` version. ### Notes to the reviewers It's OK to use rust `stable` version for clippy because we already have a `clippy.toml` file to tell it which version of the clippy rules to check against. ### Changelog notice None ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: evanlinjin: ACK e7fbc8b Tree-SHA512: 4e9e12488d44a940ea80ecc32ae74dade13d04d5088cb2206271401a2d77b56407af36482df952354b187a52b83631dcdf53bd60d9084a910f4be278059df93b
2 parents b13505c + e7fbc8b commit b5612f2

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/cont_integration.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cargo update -p zip --precise "0.6.2"
3434
cargo update -p time --precise "0.3.20"
3535
cargo update -p jobserver --precise "0.1.26"
36-
cargo update -p reqwest --precise "0.11.19"
36+
cargo update -p home --precise "0.5.5"
3737
- name: Build
3838
run: cargo build ${{ matrix.features }}
3939
- name: Test
@@ -118,9 +118,7 @@ jobs:
118118
- uses: actions/checkout@v1
119119
- uses: actions-rs/toolchain@v1
120120
with:
121-
# we pin clippy instead of using "stable" so that our CI doesn't break
122-
# at each new cargo release
123-
toolchain: "1.67.0"
121+
toolchain: "stable"
124122
components: clippy
125123
override: true
126124
- name: Rust Cache

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,14 @@ This library should compile with any combination of features with Rust 1.63.0.
6565
To build with the MSRV you will need to pin dependencies as follows:
6666

6767
```shell
68-
# zip 0.6.3 has MSRV 1.64.0+
68+
# zip 0.6.3 has MSRV 1.64.0
6969
cargo update -p zip --precise "0.6.2"
70-
# time 0.3.21 has MSRV 1.65.0+
70+
# time 0.3.21 has MSRV 1.65.0
7171
cargo update -p time --precise "0.3.20"
7272
# jobserver 0.1.27 has MSRV 1.66.0
7373
cargo update -p jobserver --precise "0.1.26"
74-
# reqwest 0.11.20 has MSRV > 1.63.0+
75-
cargo update -p reqwest --precise "0.11.19"
74+
# home 0.5.9 has MSRV 1.70.0
75+
cargo update -p home --precise "0.5.5"
7676
```
7777

7878
## License

0 commit comments

Comments
 (0)