refactor(chain)!: Change trust_predicate to accept FullTxOut

BREAKING CHANGE: The trust_predicate parameter in CanonicalView::balance()
now takes &FullTxOut<A> instead of ScriptBuf as its second argument.

This provides more context to the predicate function.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: evanlinjin

crates/chain/src/canonical_view.rs

@@ -355,7 +355,7 @@ impl<A: Anchor> CanonicalView<A> {
     pub fn balance<'v, O: Clone + 'v>(
         &'v self,
         outpoints: impl IntoIterator<Item = (O, OutPoint)> + 'v,
-        mut trust_predicate: impl FnMut(&O, ScriptBuf) -> bool,
+        mut trust_predicate: impl FnMut(&O, &FullTxOut<A>) -> bool,
         additional_confirmations: u32,
     ) -> Balance {
         let mut immature = Amount::ZERO;
@@ -376,7 +376,7 @@ impl<A: Anchor> CanonicalView<A> {
 
                     if confirmations < required_confirmations {
                         // Not enough confirmations, treat as trusted/untrusted pending
-                        if trust_predicate(&spk_i, txout.txout.script_pubkey) {
+                        if trust_predicate(&spk_i, &txout) {
                             trusted_pending += txout.txout.value;
                         } else {
                             untrusted_pending += txout.txout.value;
@@ -388,7 +388,7 @@ impl<A: Anchor> CanonicalView<A> {
                     }
                 }
                 ChainPosition::Unconfirmed { .. } => {
-                    if trust_predicate(&spk_i, txout.txout.script_pubkey) {
+                    if trust_predicate(&spk_i, &txout) {
                         trusted_pending += txout.txout.value;
                     } else {
                         untrusted_pending += txout.txout.value;

crates/chain/tests/test_indexed_tx_graph.rs

@@ -473,7 +473,7 @@ fn test_list_owned_txouts() {
                 .canonical_view(&local_chain, chain_tip, CanonicalizationParams::default())
                 .balance(
                     graph.index.outpoints().iter().cloned(),
-                    |_, spk: ScriptBuf| trusted_spks.contains(&spk),
+                    |_, txout| trusted_spks.contains(&txout.txout.script_pubkey),
                     0,
                 );
 

crates/chain/tests/test_tx_graph_conflicts.rs

@@ -5,7 +5,7 @@ mod common;
 
 use bdk_chain::{local_chain::LocalChain, Balance, BlockId};
 use bdk_testenv::{block_id, hash, local_chain};
-use bitcoin::{Amount, BlockHash, OutPoint, ScriptBuf};
+use bitcoin::{Amount, BlockHash, OutPoint};
 use common::*;
 use std::collections::{BTreeSet, HashSet};
 
@@ -1032,8 +1032,12 @@ fn test_tx_conflict_handling() {
             .canonical_view(&local_chain, chain_tip, env.canonicalization_params.clone())
             .balance(
                 env.indexer.outpoints().iter().cloned(),
-                |_, spk: ScriptBuf| env.indexer.index_of_spk(spk).is_some(),
-                1,
+                |_, txout| {
+                    env.indexer
+                        .index_of_spk(txout.txout.script_pubkey.clone())
+                        .is_some()
+                },
+                0,
             );
         assert_eq!(
             balance, scenario.exp_balance,