Skip to content

chore: fix MSRV for flate2 #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2023
Merged

chore: fix MSRV for flate2 #1182

merged 2 commits into from
Nov 6, 2023

Conversation

@evanlinjin
Copy link
Member

No description provided.

@evanlinjin
Copy link
Member Author

It's still broken, will revisit later (unless if someone would like to take over).

@realeinherjar
Copy link
Contributor

I think that rustls:0.21.7 needs to be changed to rustls:0.21.8

@notmandatory notmandatory mentioned this pull request Oct 30, 2023
Merged
3 tasks
@notmandatory
Copy link
Member

This is ready to re-review and merge. I don't want to have a broken CI holding up merging other PRs while we wait to figure out if it's OK to bump our MSRV with #1183.

@notmandatory
Copy link
Member

I had to downgrade hashbrown since I can't even do a cargo update otherwise. It looks like the 0.10 and 0.11 versions are pointing to yanked versions of ahash.

notmandatory
notmandatory approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

realeinherjar
realeinherjar approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

@nondiremanuel nondiremanuel mentioned this pull request Nov 5, 2023
Closed
38 tasks
evanlinjin
evanlinjin commented Nov 6, 2023
View reviewed changes
Copy link
Member Author

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

@evanlinjin evanlinjin merged commit 2f2f138 into bitcoindevkit:master Nov 6, 2023
This was referenced Nov 7, 2023
Closed
Merged
@LagginTimes LagginTimes mentioned this pull request Nov 8, 2023
Merged
6 tasks
@nondiremanuel nondiremanuel mentioned this pull request Nov 19, 2023
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

+1 more reviewer

@realeinherjar realeinherjar realeinherjar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evanlinjin @realeinherjar @notmandatory @vladimirfomene