-
Notifications
You must be signed in to change notification settings - Fork 37
chore: bump dev to 2.2.0-alpha.0
#294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dev to 2.2.0-alpha.0
#294
Conversation
I can update it in case we are aiming straight to 3.0.0-alpha.0 instead. |
I would also suggest using the |
I think it will need a rebase on master. |
What is needed here IMO is to just cut a new branch called Once this is done, As a side note, I think there should be a |
Do you anticipate a user needing a version like |
Yeah you absolutely can (just push fixes to the latest feature release of a major release), but I think in general having branches for each allows you to do it if you wanted to. It also makes it explicit that patches only go on the latest feature release if that's the only branch that gets a bump (say Of course this is just my 2 sats. On bdk-ffi you can find all feature releases get their own branches. But honestly it doesn't impact the workflow immensely, I just figured I'd share/point it out. I'll ACK this whether it's for merging on |
I'm fine with renaming the branch to
Yes but releases below 1.0 are semver incompatible and can be treated as the major version for all intents and purposes. |
Ok I see you have a |
Yep agree with all your points above. It's mostly cosmetic, and in reality you're unlikely to port patches back. I like our workflow, but don't take my comment + approach as the only one! |
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
just p
before pushingNew Features:
Bugfixes: