fix: return slotsealed when dump omits pubkey

reez · reez · commit ff77aeef20ed · 2025-10-08T15:57:45.000-05:00
diff --git a/lib/src/sats_card.rs b/lib/src/sats_card.rs
@@ -261,8 +261,11 @@ impl SatsCard {
             }
         }
 
-        // at this point pubkey must be available
-        let pubkey_bytes = dump_response.pubkey.unwrap();
+        // at this point the card is expected to include the pubkey; if not, treat it as sealed.
+        let pubkey_bytes = match dump_response.pubkey {
+            Some(bytes) => bytes,
+            None => return Err(DumpError::SlotSealed(slot)),
+        };
         let pubkey = PublicKey::from_slice(&pubkey_bytes)?;
 
         // TODO use chaincode and master public key to verify pubkey or return error

Original file line number	Diff line number	Diff line change
`@@ -261,8 +261,11 @@ impl SatsCard {`
`261`	`261`	`}`
`262`	`262`	`}`
`263`	`263`
`264`		`- // at this point pubkey must be available`
`265`		`- let pubkey_bytes = dump_response.pubkey.unwrap();`
	`264`	`+ // at this point the card is expected to include the pubkey; if not, treat it as sealed.`
	`265`	`+ let pubkey_bytes = match dump_response.pubkey {`
	`266`	`+ Some(bytes) => bytes,`
	`267`	`+ None => return Err(DumpError::SlotSealed(slot)),`
	`268`	`+ };`
`266`	`269`	`let pubkey = PublicKey::from_slice(&pubkey_bytes)?;`
`267`	`270`
`268`	`271`	`// TODO use chaincode and master public key to verify pubkey or return error`