Skip to content

Commit 09a0eb9

Browse files
committed
#4 do not add empty redeem script name
1 parent f1d04ce commit 09a0eb9

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

src/payments/p2sh.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ function p2sh(a, opts) {
9595
});
9696
lazy.prop(o, 'name', () => {
9797
const nameParts = ['p2sh'];
98-
if (o.redeem !== undefined) nameParts.push(o.redeem.name);
98+
if (o.redeem !== undefined && o.redeem.name !== undefined)
99+
nameParts.push(o.redeem.name);
99100
return nameParts.join('-');
100101
});
101102
if (opts.validate) {

src/payments/p2wsh.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ function p2wsh(a, opts) {
118118
});
119119
lazy.prop(o, 'name', () => {
120120
const nameParts = ['p2wsh'];
121-
if (o.redeem !== undefined) nameParts.push(o.redeem.name);
121+
if (o.redeem !== undefined && o.redeem.name !== undefined)
122+
nameParts.push(o.redeem.name);
122123
return nameParts.join('-');
123124
});
124125
// extended validation

ts_src/payments/p2sh.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ export function p2sh(a: Payment, opts?: PaymentOpts): Payment {
118118
});
119119
lazy.prop(o, 'name', () => {
120120
const nameParts = ['p2sh'];
121-
if (o.redeem !== undefined) nameParts.push(o.redeem.name!);
121+
if (o.redeem !== undefined && o.redeem.name !== undefined)
122+
nameParts.push(o.redeem.name!);
122123
return nameParts.join('-');
123124
});
124125

ts_src/payments/p2wsh.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ export function p2wsh(a: Payment, opts?: PaymentOpts): Payment {
132132
});
133133
lazy.prop(o, 'name', () => {
134134
const nameParts = ['p2wsh'];
135-
if (o.redeem !== undefined) nameParts.push(o.redeem.name!);
135+
if (o.redeem !== undefined && o.redeem.name !== undefined)
136+
nameParts.push(o.redeem.name!);
136137
return nameParts.join('-');
137138
});
138139

0 commit comments

Comments
 (0)