fix: tests for nodev18

Author: Nesopie

package-lock.json

@@ -4,17 +4,20 @@ import * as ecc from 'tiny-secp256k1';
 import { describe, it } from 'mocha';
 import * as bitcoin from 'bitcoinjs-lib';
 import { regtestUtils } from './_regtest.js';
+import { randomBytes } from 'crypto';
 
 const ECPair = ECPairFactory(ecc);
 const dhttp = regtestUtils.dhttp;
 const TESTNET = bitcoin.networks.testnet;
 
+const rng = (size: number) => randomBytes(size);
+
 describe('bitcoinjs-lib (addresses)', () => {
   it(
     'can generate a random address [and support the retrieval of ' +
       'transactions for that address (via 3PBP)]',
     async () => {
-      const keyPair = ECPair.makeRandom();
+      const keyPair = ECPair.makeRandom({ rng });
       const { address } = bitcoin.payments.p2pkh({ pubkey: keyPair.publicKey });
 
       // bitcoin P2PKH addresses start with a '1'
@@ -107,7 +110,7 @@ describe('bitcoinjs-lib (addresses)', () => {
 
   // examples using other network information
   it('can generate a Testnet address', () => {
-    const keyPair = ECPair.makeRandom({ network: TESTNET });
+    const keyPair = ECPair.makeRandom({ network: TESTNET, rng });
     const { address } = bitcoin.payments.p2pkh({
       pubkey: keyPair.publicKey,
       network: TESTNET,
@@ -134,7 +137,7 @@ describe('bitcoinjs-lib (addresses)', () => {
       wif: 0xb0,
     };
 
-    const keyPair = ECPair.makeRandom({ network: LITECOIN });
+    const keyPair = ECPair.makeRandom({ network: LITECOIN, rng });
     const { address } = bitcoin.payments.p2pkh({
       pubkey: keyPair.publicKey,
       network: LITECOIN,

test/integration/addresses.spec.ts

@@ -3,12 +3,15 @@ import * as ecc from 'tiny-secp256k1';
 import { describe, it } from 'mocha';
 import * as bitcoin from 'bitcoinjs-lib';
 import { regtestUtils } from './_regtest.js';
+import { randomBytes } from 'crypto';
 
 import p2msFixtures from '../fixtures/p2ms.json';
 import p2pkFixtures from '../fixtures/p2pk.json';
 import p2pkhFixtures from '../fixtures/p2pkh.json';
 import p2wpkhFixtures from '../fixtures/p2wpkh.json';
 
+const rng = (size: number) => randomBytes(size);
+
 const testSuite = [
   {
     paymentName: 'p2ms',
@@ -31,8 +34,8 @@ const testSuite = [
 const ECPair = ECPairFactory(ecc);
 const NETWORK = regtestUtils.network;
 const keyPairs = [
-  ECPair.makeRandom({ network: NETWORK }),
-  ECPair.makeRandom({ network: NETWORK }),
+  ECPair.makeRandom({ network: NETWORK, rng }),
+  ECPair.makeRandom({ network: NETWORK, rng }),
 ];
 
 async function buildAndSign(

test/integration/payments.spec.ts

@@ -543,7 +543,7 @@ describe('bitcoinjs-lib (transactions with psbt)', () => {
     'can create (and broadcast via 3PBP) a Transaction, w/ a ' +
       'P2SH(P2MS(2 of 2)) input with nonWitnessUtxo',
     async () => {
-      const myKey = ECPair.makeRandom({ network: regtest });
+      const myKey = ECPair.makeRandom({ network: regtest, rng });
       const myKeys = [
         myKey,
         ECPair.fromPrivateKey(myKey.privateKey!, { network: regtest }),
@@ -647,11 +647,11 @@ function createPayment(_type: string, myKeys?: any[], network?: any): any {
       throw new Error('Need n keys for multisig');
     }
     while (!myKeys && n > 1) {
-      keys.push(ECPair.makeRandom({ network }));
+      keys.push(ECPair.makeRandom({ network, rng }));
       n--;
     }
   }
-  if (!myKeys) keys.push(ECPair.makeRandom({ network }));
+  if (!myKeys) keys.push(ECPair.makeRandom({ network, rng }));
 
   let payment: any;
   splitType.forEach(type => {

test/integration/transactions.spec.ts

@@ -12,6 +12,8 @@ import type { Taptree } from 'bitcoinjs-lib/src/types';
 import { initEccLib } from 'bitcoinjs-lib';
 import * as tools from 'uint8array-tools';
 
+const rng = (size: number) => crypto.randomBytes(size);
+
 const bip32 = BIP32Factory.BIP32Factory(ecc);
 const ECPair = ECPairFactory(ecc);
 
@@ -134,7 +136,7 @@ describe(`Psbt`, () => {
     });
 
     fixtures.bip174.failSignChecks.forEach(f => {
-      const keyPair = ECPair.makeRandom();
+      const keyPair = ECPair.makeRandom({ rng });
       it(`Fails Signer checks: ${f.description}`, () => {
         const psbt = Psbt.fromBase64(f.psbt);
         assert.throws(() => {
@@ -720,7 +722,7 @@ describe(`Psbt`, () => {
   });
 
   describe('getInputType', () => {
-    const key = ECPair.makeRandom();
+    const key = ECPair.makeRandom({ rng });
     const { publicKey } = key;
     const p2wpkhPub = (pubkey: Uint8Array): Uint8Array =>
       payments.p2wpkh({