Merge pull request #2170 from JacksonDMiller/JacksonDMiller-addStripWitnessToTransactionMaster

Add stripWitness to Transaction Issue 2169

Author: junderw

src/cjs/transaction.cjs

@@ -203,6 +203,11 @@ class Transaction {
       return x.witness.length !== 0;
     });
   }
+  stripWitnesses() {
+    this.ins.forEach(input => {
+      input.witness = EMPTY_WITNESS; // Set witness data to an empty array
+    });
+  }
   weight() {
     const base = this.byteLength(false);
     const total = this.byteLength(true);

src/cjs/transaction.d.ts

@@ -34,6 +34,7 @@ export declare class Transaction {
     addInput(hash: Uint8Array, index: number, sequence?: number, scriptSig?: Uint8Array): number;
     addOutput(scriptPubKey: Uint8Array, value: bigint): number;
     hasWitnesses(): boolean;
+    stripWitnesses(): void;
     weight(): number;
     virtualSize(): number;
     byteLength(_ALLOW_WITNESS?: boolean): number;

src/esm/transaction.js

@@ -161,6 +161,11 @@ export class Transaction {
       return x.witness.length !== 0;
     });
   }
+  stripWitnesses() {
+    this.ins.forEach(input => {
+      input.witness = EMPTY_WITNESS; // Set witness data to an empty array
+    });
+  }
   weight() {
     const base = this.byteLength(false);
     const total = this.byteLength(true);

test/transaction.spec.ts

@@ -135,6 +135,16 @@ describe('Transaction', () => {
     });
   });
 
+  describe('stripWitnesses', () => {
+    fixtures.valid.forEach(f => {
+      it('removes witness from the transaction if it exists', () => {
+        const T = Transaction.fromHex(f.whex ? f.whex : f.hex);
+        T.stripWitnesses();
+        assert.strictEqual(T.hasWitnesses(), false);
+      });
+    });
+  });
+
   describe('weight/virtualSize', () => {
     it('computes virtual size', () => {
       fixtures.valid.forEach(f => {

ts_src/transaction.ts

@@ -208,6 +208,12 @@ export class Transaction {
     });
   }
 
+  stripWitnesses(): void {
+    this.ins.forEach(input => {
+      input.witness = EMPTY_WITNESS; // Set witness data to an empty array
+    });
+  }
+
   weight(): number {
     const base = this.byteLength(false);
     const total = this.byteLength(true);